Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Unified Diff: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

Issue 2840663002: DevTools: clicking in console messages should not jump to bottom (Closed)
Patch Set: ac Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
diff --git a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
index be61b1a8bbe8206cb165e078dad479ca8235a504..4b64e341956d1d2e0fd76b6106afe7fadfd71212 100644
--- a/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
+++ b/third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js
@@ -307,12 +307,8 @@ Console.ConsoleView = class extends UI.VBox {
* @override
*/
focus() {
- if (this._prompt.hasFocus())
- return;
- // Set caret position before setting focus in order to avoid scrolling
- // by focus().
- this._prompt.moveCaretToEndOfPrompt();
- this._prompt.focus();
+ if (!this._prompt.hasFocus())
+ this._prompt.focus();
}
/**
@@ -666,8 +662,14 @@ Console.ConsoleView = class extends UI.VBox {
*/
_messagesClicked(event) {
var targetElement = event.deepElementFromPoint();
- if (!targetElement || targetElement.isComponentSelectionCollapsed())
+
+ // Do not focus prompt if messages have selection.
+ if (!targetElement || targetElement.isComponentSelectionCollapsed()) {
+ var clickedOutsideMessageList = event.target === this._messagesElement;
+ if (clickedOutsideMessageList)
+ this._prompt.moveCaretToEndOfPrompt();
this.focus();
+ }
var groupMessage = event.target.enclosingNodeOrSelfWithClass('console-group-title');
if (!groupMessage)
return;

Powered by Google App Engine
This is Rietveld 408576698