DevTools: clicking in console messages should not jump to bottom

third_party/WebKit/Source/devtools/front_end/console/ConsoleView.js

 /*
  * Copyright (C) 2007, 2008 Apple Inc.  All rights reserved.
  * Copyright (C) 2009 Joseph Pecoraro
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1.  Redistributions of source code must retain the above copyright
  *     notice, this list of conditions and the following disclaimer.
@@ skipping 291 matching lines @@
   wasShown() {
     this._viewport.refresh();
   }
 
   /**
    * @override
    */
   focus() {
     if (this._prompt.hasFocus())
       return;
-    // Set caret position before setting focus in order to avoid scrolling
-    // by focus().
     this._prompt.moveCaretToEndOfPrompt();

[pfeldman, 2017/04/25 07:29:30]

We probably should no longer call moveCaretToEndOfPrompt since we are no longer
trying to preserve scroll position. However, this does not fix the regression
when switching from Console to another tab and back was losing focus.

[luoe, 2017/04/25 18:11:39]

You're right, this patch reintroduces the old regression.  I didn't realize
this, so I added a test in the latest patch set.  In this case, your CL's
approach of restoring scrollTop sounds good to me.

If possible, I would still like to keep moveCaretToEndOfPrompt, however.  Not
just for maintaining current behavior, but I find it very useful when clicking
below the prompt.

     this._prompt.focus();
   }
 
   /**
    * @override
    */
   restoreScrollPositions() {
     if (this._viewport.stickToBottom())
       this._immediatelyScrollToBottom();
     else
@@ skipping 334 matching lines @@
     this._updateFilterStatus();
     this._searchableView.updateSearchMatchesCount(this._regexMatchRanges.length);
     this._viewport.invalidate();
   }
 
   /**
    * @param {!Event} event
    */
   _messagesClicked(event) {
     var targetElement = event.deepElementFromPoint();
-    if (!targetElement || targetElement.isComponentSelectionCollapsed())
+    if (!targetElement || !targetElement.enclosingNodeOrSelfWithClass('console-group'))

[pfeldman, 2017/04/25 07:29:30]

I think !targetElement.enclosingNodeOrSelfWithClass('console-group') is always
false, when is it not the case?

[luoe, 2017/04/25 18:11:39]

When there are only a few messages, clicking in the area below the prompt
targets the viewport's element, which is a parent of the 'console-group'
messages.  In this case, the caret moves to the end.

       this.focus();
+    else if (targetElement.isComponentSelectionCollapsed())
+      this._prompt.focus();
+
     var groupMessage = event.target.enclosingNodeOrSelfWithClass('console-group-title');
     if (!groupMessage)
       return;
     var consoleGroupViewMessage = groupMessage.parentElement.message;
     consoleGroupViewMessage.setCollapsed(!consoleGroupViewMessage.collapsed());
     this._updateMessageList();
   }
 
   _registerShortcuts() {
     this._shortcuts = {};
@@ skipping 591 matching lines @@
         return true;
     }
     return false;
   }
 };
 
 /**
  * @typedef {{messageIndex: number, matchIndex: number}}
  */
 Console.ConsoleView.RegexMatchRange;