Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(534)

Side by Side Diff: chrome/browser/android/offline_pages/request_coordinator_factory.cc

Issue 2840653002: Use TaskScheduler instead of blocking pool in request_coordinator_factory.cc. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/offline_pages/request_coordinator_factory.h" 5 #include "chrome/browser/android/offline_pages/request_coordinator_factory.h"
6 6
7 #include <memory> 7 #include <memory>
8 8
9 #include "base/memory/ptr_util.h" 9 #include "base/memory/ptr_util.h"
10 #include "base/memory/singleton.h" 10 #include "base/memory/singleton.h"
11 #include "base/sequenced_task_runner.h" 11 #include "base/sequenced_task_runner.h"
12 #include "base/threading/sequenced_worker_pool.h" 12 #include "base/task_scheduler/post_task.h"
13 #include "chrome/browser/android/offline_pages/background_loader_offliner.h" 13 #include "chrome/browser/android/offline_pages/background_loader_offliner.h"
14 #include "chrome/browser/android/offline_pages/background_scheduler_bridge.h" 14 #include "chrome/browser/android/offline_pages/background_scheduler_bridge.h"
15 #include "chrome/browser/android/offline_pages/downloads/offline_page_notificati on_bridge.h" 15 #include "chrome/browser/android/offline_pages/downloads/offline_page_notificati on_bridge.h"
16 #include "chrome/browser/android/offline_pages/offline_page_model_factory.h" 16 #include "chrome/browser/android/offline_pages/offline_page_model_factory.h"
17 #include "chrome/browser/android/offline_pages/prerendering_offliner.h" 17 #include "chrome/browser/android/offline_pages/prerendering_offliner.h"
18 #include "chrome/browser/net/nqe/ui_network_quality_estimator_service.h" 18 #include "chrome/browser/net/nqe/ui_network_quality_estimator_service.h"
19 #include "chrome/browser/net/nqe/ui_network_quality_estimator_service_factory.h" 19 #include "chrome/browser/net/nqe/ui_network_quality_estimator_service_factory.h"
20 #include "chrome/browser/profiles/profile.h" 20 #include "chrome/browser/profiles/profile.h"
21 #include "chrome/common/chrome_constants.h" 21 #include "chrome/common/chrome_constants.h"
22 #include "components/keyed_service/content/browser_context_dependency_manager.h" 22 #include "components/keyed_service/content/browser_context_dependency_manager.h"
23 #include "components/offline_pages/core/background/offliner.h" 23 #include "components/offline_pages/core/background/offliner.h"
24 #include "components/offline_pages/core/background/offliner_policy.h" 24 #include "components/offline_pages/core/background/offliner_policy.h"
25 #include "components/offline_pages/core/background/request_coordinator.h" 25 #include "components/offline_pages/core/background/request_coordinator.h"
26 #include "components/offline_pages/core/background/request_queue.h" 26 #include "components/offline_pages/core/background/request_queue.h"
27 #include "components/offline_pages/core/background/request_queue_store.h" 27 #include "components/offline_pages/core/background/request_queue_store.h"
28 #include "components/offline_pages/core/background/request_queue_store_sql.h" 28 #include "components/offline_pages/core/background/request_queue_store_sql.h"
29 #include "components/offline_pages/core/background/scheduler.h" 29 #include "components/offline_pages/core/background/scheduler.h"
30 #include "components/offline_pages/core/downloads/download_notifying_observer.h" 30 #include "components/offline_pages/core/downloads/download_notifying_observer.h"
31 #include "components/offline_pages/core/offline_page_feature.h" 31 #include "components/offline_pages/core/offline_page_feature.h"
32 #include "content/public/browser/browser_thread.h"
33 #include "net/nqe/network_quality_estimator.h" 32 #include "net/nqe/network_quality_estimator.h"
34 33
35 namespace offline_pages { 34 namespace offline_pages {
36 35
37 RequestCoordinatorFactory::RequestCoordinatorFactory() 36 RequestCoordinatorFactory::RequestCoordinatorFactory()
38 : BrowserContextKeyedServiceFactory( 37 : BrowserContextKeyedServiceFactory(
39 "OfflineRequestCoordinator", 38 "OfflineRequestCoordinator",
40 BrowserContextDependencyManager::GetInstance()) { 39 BrowserContextDependencyManager::GetInstance()) {
41 DependsOn(OfflinePageModelFactory::GetInstance()); 40 DependsOn(OfflinePageModelFactory::GetInstance());
42 } 41 }
(...skipping 18 matching lines...) Expand all
61 OfflinePageModelFactory::GetInstance()->GetForBrowserContext(context); 60 OfflinePageModelFactory::GetInstance()->GetForBrowserContext(context);
62 61
63 // Determines which offliner to use based on flag. 62 // Determines which offliner to use based on flag.
64 if (ShouldUseNewBackgroundLoader()) { 63 if (ShouldUseNewBackgroundLoader()) {
65 offliner.reset(new BackgroundLoaderOffliner(context, policy.get(), model)); 64 offliner.reset(new BackgroundLoaderOffliner(context, policy.get(), model));
66 } else { 65 } else {
67 offliner.reset(new PrerenderingOffliner(context, policy.get(), model)); 66 offliner.reset(new PrerenderingOffliner(context, policy.get(), model));
68 } 67 }
69 68
70 scoped_refptr<base::SequencedTaskRunner> background_task_runner = 69 scoped_refptr<base::SequencedTaskRunner> background_task_runner =
71 content::BrowserThread::GetBlockingPool()->GetSequencedTaskRunner( 70 base::CreateSequencedTaskRunnerWithTraits(
72 content::BrowserThread::GetBlockingPool()->GetSequenceToken()); 71 base::TaskTraits().MayBlock().WithPriority(
72 base::TaskPriority::BACKGROUND));
73 Profile* profile = Profile::FromBrowserContext(context); 73 Profile* profile = Profile::FromBrowserContext(context);
74 base::FilePath queue_store_path = 74 base::FilePath queue_store_path =
75 profile->GetPath().Append(chrome::kOfflinePageRequestQueueDirname); 75 profile->GetPath().Append(chrome::kOfflinePageRequestQueueDirname);
76 76
77 std::unique_ptr<RequestQueueStoreSQL> queue_store( 77 std::unique_ptr<RequestQueueStoreSQL> queue_store(
78 new RequestQueueStoreSQL(background_task_runner, queue_store_path)); 78 new RequestQueueStoreSQL(background_task_runner, queue_store_path));
79 std::unique_ptr<RequestQueue> queue(new RequestQueue(std::move(queue_store))); 79 std::unique_ptr<RequestQueue> queue(new RequestQueue(std::move(queue_store)));
80 std::unique_ptr<Scheduler> 80 std::unique_ptr<Scheduler>
81 scheduler(new android::BackgroundSchedulerBridge()); 81 scheduler(new android::BackgroundSchedulerBridge());
82 net::NetworkQualityEstimator::NetworkQualityProvider* 82 net::NetworkQualityEstimator::NetworkQualityProvider*
83 network_quality_estimator = 83 network_quality_estimator =
84 UINetworkQualityEstimatorServiceFactory::GetForProfile(profile); 84 UINetworkQualityEstimatorServiceFactory::GetForProfile(profile);
85 RequestCoordinator* request_coordinator = new RequestCoordinator( 85 RequestCoordinator* request_coordinator = new RequestCoordinator(
86 std::move(policy), std::move(offliner), std::move(queue), 86 std::move(policy), std::move(offliner), std::move(queue),
87 std::move(scheduler), network_quality_estimator); 87 std::move(scheduler), network_quality_estimator);
88 88
89 DownloadNotifyingObserver::CreateAndStartObserving( 89 DownloadNotifyingObserver::CreateAndStartObserving(
90 request_coordinator, 90 request_coordinator,
91 base::MakeUnique<android::OfflinePageNotificationBridge>()); 91 base::MakeUnique<android::OfflinePageNotificationBridge>());
92 92
93 return request_coordinator; 93 return request_coordinator;
94 } 94 }
95 95
96 } // namespace offline_pages 96 } // namespace offline_pages
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698