Issue 2840613004: Revert "dart2js: --fast-startup: use alias for 'this'"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2840613004: Revert "dart2js: --fast-startup: use alias for 'this'" (Closed)

Created:
3 years, 8 months ago by sra1

Modified:
3 years, 8 months ago

Reviewers:

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Revert "dart2js: --fast-startup: use alias for 'this'" Need to solve a clash between field name and local name in unminified code when the field is named '_'. BUG= Committed: https://github.com/dart-lang/sdk/commit/840f655b88a985a500a3538e503d21507f1287fe

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -23 lines)			Patch
	M	pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart	View		1 chunk	+13 lines, -23 lines	0 comments	Download

Total messages: 2 (1 generated)

sra1

3 years, 8 months ago (2017-04-25 01:02:39 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
840f655b88a985a500a3538e503d21507f1287fe (presubmit successful).