Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Unified Diff: build/android/pylib/instrumentation/instrumentation_test_instance.py

Issue 2840573002: [android] Clean up a couple of unnecessary test runner log warnings. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/android/pylib/valgrind_tools.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/android/pylib/instrumentation/instrumentation_test_instance.py
diff --git a/build/android/pylib/instrumentation/instrumentation_test_instance.py b/build/android/pylib/instrumentation/instrumentation_test_instance.py
index d01e36eeeee8a84eba18096a487f0a75eb4ac678..d8f0995269327ff03c4407424f3b5c37fb86d0a1 100644
--- a/build/android/pylib/instrumentation/instrumentation_test_instance.py
+++ b/build/android/pylib/instrumentation/instrumentation_test_instance.py
@@ -685,7 +685,7 @@ class InstrumentationTestInstance(test_instance.TestInstance):
self._should_save_logcat = bool(args.json_results_file)
def _initializeEditPrefsAttributes(self, args):
- if not hasattr(args, 'shared_prefs_file'):
+ if not hasattr(args, 'shared_prefs_file') or not args.shared_prefs_file:
return
if not isinstance(args.shared_prefs_file, str):
logging.warning("Given non-string for a filepath")
« no previous file with comments | « no previous file | build/android/pylib/valgrind_tools.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698