Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Unified Diff: third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp

Issue 2840473002: Worker: Remove WorkerLoaderProxy for clean-up (Closed)
Patch Set: wip Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp
diff --git a/third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp b/third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp
index b979310f5ca99f5a640cb923d5a6f4b34b77d3f7..3d08d8424333983c9ec20e67129cc65e052795ca 100644
--- a/third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp
+++ b/third_party/WebKit/Source/core/workers/ThreadedWorkletTest.cpp
@@ -22,11 +22,9 @@ namespace blink {
class ThreadedWorkletThreadForTest : public WorkerThread {
public:
- ThreadedWorkletThreadForTest(
- WorkerLoaderProxyProvider* worker_loader_proxy_provider,
+ explicit ThreadedWorkletThreadForTest(
WorkerReportingProxy& worker_reporting_proxy)
- : WorkerThread(WorkerLoaderProxy::Create(worker_loader_proxy_provider),
- worker_reporting_proxy) {}
+ : WorkerThread(nullptr, worker_reporting_proxy) {}
~ThreadedWorkletThreadForTest() override{};
WorkerBackingThread& GetWorkerBackingThread() override {
@@ -91,16 +89,12 @@ class ThreadedWorkletMessagingProxyForTest
public:
ThreadedWorkletMessagingProxyForTest(ExecutionContext* execution_context)
: ThreadedWorkletMessagingProxy(execution_context) {
- worker_loader_proxy_provider_ =
- WTF::MakeUnique<WorkerLoaderProxyProvider>();
- worker_thread_ = WTF::MakeUnique<ThreadedWorkletThreadForTest>(
- worker_loader_proxy_provider_.get(), WorkletObjectProxy());
+ worker_thread_ =
+ WTF::MakeUnique<ThreadedWorkletThreadForTest>(WorkletObjectProxy());
ThreadedWorkletThreadForTest::EnsureSharedBackingThread();
}
~ThreadedWorkletMessagingProxyForTest() override {
- worker_thread_->GetWorkerLoaderProxy()->DetachProvider(
- worker_loader_proxy_provider_.get());
worker_thread_->TerminateAndWait();
ThreadedWorkletThreadForTest::ClearSharedBackingThread();
};
@@ -136,7 +130,6 @@ class ThreadedWorkletMessagingProxyForTest
private:
friend class ThreadedWorkletTest;
- std::unique_ptr<WorkerLoaderProxyProvider> worker_loader_proxy_provider_;
RefPtr<SecurityOrigin> security_origin_;
};

Powered by Google App Engine
This is Rietveld 408576698