Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(798)

Unified Diff: third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp

Issue 2840473002: Worker: Remove WorkerLoaderProxy for clean-up (Closed)
Patch Set: clean up Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp
diff --git a/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp b/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp
index f141dab2f92a5c882dd4a1e72c1f1fbabab0a211..6c87a6c8e72a1e061b141c71c0f96ce32b6d0228 100644
--- a/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp
+++ b/third_party/WebKit/Source/core/workers/WorkerThreadTest.cpp
@@ -67,20 +67,16 @@ class WorkerThreadTest : public ::testing::Test {
WorkerThreadTest() {}
void SetUp() override {
- loader_proxy_provider_ = WTF::MakeUnique<WorkerLoaderProxyProvider>();
reporting_proxy_ = WTF::MakeUnique<MockWorkerReportingProxy>();
security_origin_ =
SecurityOrigin::Create(KURL(kParsedURLString, "http://fake.url/"));
- worker_thread_ = WTF::WrapUnique(new WorkerThreadForTest(
- loader_proxy_provider_.get(), *reporting_proxy_));
+ worker_thread_ =
+ WTF::WrapUnique(new WorkerThreadForTest(nullptr, *reporting_proxy_));
lifecycle_observer_ = new MockWorkerThreadLifecycleObserver(
worker_thread_->GetWorkerThreadLifecycleContext());
}
- void TearDown() override {
- worker_thread_->GetWorkerLoaderProxy()->DetachProvider(
- loader_proxy_provider_.get());
- }
+ void TearDown() override {}
void Start() {
worker_thread_->StartWithSourceCode(
@@ -143,7 +139,6 @@ class WorkerThreadTest : public ::testing::Test {
ExitCode GetExitCode() { return worker_thread_->GetExitCodeForTesting(); }
RefPtr<SecurityOrigin> security_origin_;
- std::unique_ptr<WorkerLoaderProxyProvider> loader_proxy_provider_;
std::unique_ptr<MockWorkerReportingProxy> reporting_proxy_;
std::unique_ptr<WorkerThreadForTest> worker_thread_;
Persistent<MockWorkerThreadLifecycleObserver> lifecycle_observer_;

Powered by Google App Engine
This is Rietveld 408576698