Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(638)

Side by Side Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerThread.cpp

Issue 2840473002: Worker: Remove WorkerLoaderProxy for clean-up (Closed)
Patch Set: wip Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 21 matching lines...) Expand all
32 32
33 #include <memory> 33 #include <memory>
34 #include "core/workers/WorkerBackingThread.h" 34 #include "core/workers/WorkerBackingThread.h"
35 #include "core/workers/WorkerThreadStartupData.h" 35 #include "core/workers/WorkerThreadStartupData.h"
36 #include "modules/serviceworkers/ServiceWorkerGlobalScope.h" 36 #include "modules/serviceworkers/ServiceWorkerGlobalScope.h"
37 #include "platform/wtf/PtrUtil.h" 37 #include "platform/wtf/PtrUtil.h"
38 38
39 namespace blink { 39 namespace blink {
40 40
41 std::unique_ptr<ServiceWorkerThread> ServiceWorkerThread::Create( 41 std::unique_ptr<ServiceWorkerThread> ServiceWorkerThread::Create(
42 PassRefPtr<WorkerLoaderProxy> worker_loader_proxy, 42 ThreadableLoadingContext* loading_context,
43 WorkerReportingProxy& worker_reporting_proxy) { 43 WorkerReportingProxy& worker_reporting_proxy) {
44 return WTF::WrapUnique(new ServiceWorkerThread(std::move(worker_loader_proxy), 44 return WTF::WrapUnique(
45 worker_reporting_proxy)); 45 new ServiceWorkerThread(loading_context, worker_reporting_proxy));
haraken 2017/04/25 16:53:43 MakeUnique
nhiroki 2017/05/29 04:20:24 Done.
46 } 46 }
47 47
48 ServiceWorkerThread::ServiceWorkerThread( 48 ServiceWorkerThread::ServiceWorkerThread(
49 PassRefPtr<WorkerLoaderProxy> worker_loader_proxy, 49 ThreadableLoadingContext* loading_context,
50 WorkerReportingProxy& worker_reporting_proxy) 50 WorkerReportingProxy& worker_reporting_proxy)
51 : WorkerThread(std::move(worker_loader_proxy), worker_reporting_proxy), 51 : WorkerThread(loading_context, worker_reporting_proxy),
52 worker_backing_thread_( 52 worker_backing_thread_(
53 WorkerBackingThread::Create("ServiceWorker Thread")) {} 53 WorkerBackingThread::Create("ServiceWorker Thread")) {}
54 54
55 ServiceWorkerThread::~ServiceWorkerThread() {} 55 ServiceWorkerThread::~ServiceWorkerThread() {}
56 56
57 void ServiceWorkerThread::ClearWorkerBackingThread() { 57 void ServiceWorkerThread::ClearWorkerBackingThread() {
58 worker_backing_thread_ = nullptr; 58 worker_backing_thread_ = nullptr;
59 } 59 }
60 60
61 WorkerOrWorkletGlobalScope* ServiceWorkerThread::CreateWorkerGlobalScope( 61 WorkerOrWorkletGlobalScope* ServiceWorkerThread::CreateWorkerGlobalScope(
62 std::unique_ptr<WorkerThreadStartupData> startup_data) { 62 std::unique_ptr<WorkerThreadStartupData> startup_data) {
63 return ServiceWorkerGlobalScope::Create(this, std::move(startup_data)); 63 return ServiceWorkerGlobalScope::Create(this, std::move(startup_data));
64 } 64 }
65 65
66 } // namespace blink 66 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698