Issue 2840453003: Mark co19 test as failing on Firefox.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2840453003: Mark co19 test as failing on Firefox. (Closed)

Created:
3 years, 8 months ago by Lasse Reichstein Nielsen

Modified:
3 years, 8 months ago

Reviewers:
Bill Hesse

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Mark co19 test as failing on Firefox. Committed: https://github.com/dart-lang/sdk/commit/931a8e824d7d6cbc89aa7837334b75dd50be64b8

Patch Set 1 #

Total comments: 1

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -0 lines)			Patch
	M	tests/co19/co19-co19.status	View		1 chunk	+3 lines, -0 lines	1 comment	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Lasse Reichstein Nielsen

Committed patchset #1 (id:1) manually as 931a8e824d7d6cbc89aa7837334b75dd50be64b8 (presubmit successful).

3 years, 8 months ago (2017-04-24 10:55:52 UTC) #4

Bill Hesse

This belongs in the corresponding section of co19-dart2js.status, not in co19-co19.status.

3 years, 8 months ago (2017-04-24 11:11:41 UTC) #5

Bill Hesse

3 years, 8 months ago (2017-04-24 11:43:03 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/2840453003/diff/1/tests/co19/co19-co19.status
File tests/co19/co19-co19.status (right):

https://codereview.chromium.org/2840453003/diff/1/tests/co19/co19-co19.status...
tests/co19/co19-co19.status:10: # In order to qualify here these tests need to
fail both on the VM and dart2js.
Please make this sentence in all caps, if it needs to be emphasized.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages