Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Unified Diff: Source/platform/graphics/ImageSource.h

Issue 284043003: Looping of animated WebP: Loop count off-by-one (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/platform/graphics/ImageSource.h
diff --git a/Source/platform/graphics/ImageSource.h b/Source/platform/graphics/ImageSource.h
index e431db94bb9bba6cde4cafbe4fab3a971f05557f..487b5e9d26be8e688d1502ff8bfdb8e4d61edb49 100644
--- a/Source/platform/graphics/ImageSource.h
+++ b/Source/platform/graphics/ImageSource.h
@@ -42,8 +42,8 @@ class IntSize;
class NativeImageSkia;
class SharedBuffer;
-// Right now GIFs are the only recognized image format that supports animation.
-// The animation system and the constants below are designed with this in mind.
+// Right now GIFs and WebPs are the only recognized image formats that support animation.
+// But the animation system and the constants below are designed with GIFs in mind.
Peter Kasting 2014/05/14 21:47:04 Nit: How about: // GIF and WebP support animati
urvang (Google) 2014/05/14 22:19:50 Done.
// GIFs have an optional 16-bit unsigned loop count that describes how an
// animated GIF should be cycled. If the loop count is absent, the animation
// cycles once; if it is 0, the animation cycles infinitely; otherwise the
@@ -108,6 +108,11 @@ public:
bool getHotSpot(IntPoint&) const;
+ // If return value is 'r', then:
+ // * If r == cAnimationNone, then it is a non-animated image.
+ // * If r == cAnimationLoopInfinite, then animation play infinitely.
+ // * Otherwise, animation plays |r + 1| times.
Peter Kasting 2014/05/14 21:47:04 Nit: How about: // Returns one of the cAnimat
urvang (Google) 2014/05/14 22:19:50 Done.
+ // See comment at the top of this file for more info.
int repetitionCount();
size_t frameCount() const;

Powered by Google App Engine
This is Rietveld 408576698