Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(614)

Issue 284043003: Looping of animated WebP: Loop count off-by-one (Closed)

Created:
6 years, 7 months ago by urvang (Google)
Modified:
6 years, 7 months ago
Reviewers:
Nico, Peter Kasting
CC:
vikasa, jzern, skal, urvang (Google), abarth-chromium
Visibility:
Public.

Description

Looping of animated WebP: Loop count off-by-one Animation system cycles animated images repetitionCount() + 1 times. So, need to set repetitionCount to one less than actual. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174323

Patch Set 1 #

Total comments: 6

Patch Set 2 : comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -5 lines) Patch
M Source/platform/graphics/ImageSource.h View 1 2 chunks +5 lines, -2 lines 0 comments Download
M Source/platform/image-decoders/webp/WEBPImageDecoder.cpp View 1 1 chunk +6 lines, -2 lines 0 comments Download
M Source/platform/image-decoders/webp/WEBPImageDecoderTest.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
urvang (Google)
6 years, 7 months ago (2014-05-14 21:02:44 UTC) #1
Peter Kasting
LGTM https://codereview.chromium.org/284043003/diff/1/Source/platform/graphics/ImageSource.h File Source/platform/graphics/ImageSource.h (right): https://codereview.chromium.org/284043003/diff/1/Source/platform/graphics/ImageSource.h#newcode46 Source/platform/graphics/ImageSource.h:46: // But the animation system and the constants ...
6 years, 7 months ago (2014-05-14 21:47:03 UTC) #2
urvang (Google)
Thanks! Updated comments. https://codereview.chromium.org/284043003/diff/1/Source/platform/graphics/ImageSource.h File Source/platform/graphics/ImageSource.h (right): https://codereview.chromium.org/284043003/diff/1/Source/platform/graphics/ImageSource.h#newcode46 Source/platform/graphics/ImageSource.h:46: // But the animation system and ...
6 years, 7 months ago (2014-05-14 22:19:50 UTC) #3
Nico
lgtm stamp pkasting, should there be a Source/platform/image-decoders/OWNERS?
6 years, 7 months ago (2014-05-19 19:00:39 UTC) #4
Peter Kasting
On 2014/05/19 19:00:39, Nico wrote: > pkasting, should there be a Source/platform/image-decoders/OWNERS? If memory serves, ...
6 years, 7 months ago (2014-05-19 19:04:23 UTC) #5
urvang (Google)
[+Adam, FYI] [-Most ppl] On 2014/05/19 19:04:23, Peter Kasting wrote: > On 2014/05/19 19:00:39, Nico ...
6 years, 7 months ago (2014-05-19 19:11:18 UTC) #6
urvang (Google)
The CQ bit was checked by urvang@google.com
6 years, 7 months ago (2014-05-19 19:59:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/urvang@google.com/284043003/20001
6 years, 7 months ago (2014-05-19 19:59:18 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-19 21:25:40 UTC) #9
commit-bot: I haz the power
6 years, 7 months ago (2014-05-19 22:27:47 UTC) #10
Message was sent while issue was closed.
Change committed as 174323

Powered by Google App Engine
This is Rietveld 408576698