Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Side by Side Diff: chrome/browser/extensions/chrome_content_browser_client_extensions_part.h

Issue 2840383002: Disable top-document-isolation if the parent SiteInstance is a hosted app. (Closed)
Patch Set: Addressing CR feedback. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_EXTENSIONS_CHROME_CONTENT_BROWSER_CLIENT_EXTENSIONS_PART_ H_ 5 #ifndef CHROME_BROWSER_EXTENSIONS_CHROME_CONTENT_BROWSER_CLIENT_EXTENSIONS_PART_ H_
6 #define CHROME_BROWSER_EXTENSIONS_CHROME_CONTENT_BROWSER_CLIENT_EXTENSIONS_PART_ H_ 6 #define CHROME_BROWSER_EXTENSIONS_CHROME_CONTENT_BROWSER_CLIENT_EXTENSIONS_PART_ H_
7 7
8 #include "base/compiler_specific.h" 8 #include "base/compiler_specific.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "chrome/browser/chrome_content_browser_client_parts.h" 10 #include "chrome/browser/chrome_content_browser_client_parts.h"
(...skipping 53 matching lines...) Expand 10 before | Expand all | Expand 10 after
64 bool* result); 64 bool* result);
65 65
66 // Helper function to call InfoMap::SetSigninProcess(). 66 // Helper function to call InfoMap::SetSigninProcess().
67 static void SetSigninProcess(content::SiteInstance* site_instance); 67 static void SetSigninProcess(content::SiteInstance* site_instance);
68 68
69 // Creates a new VpnServiceProxy. The caller owns the returned value. It's 69 // Creates a new VpnServiceProxy. The caller owns the returned value. It's
70 // valid to return nullptr. 70 // valid to return nullptr.
71 static std::unique_ptr<content::VpnServiceProxy> GetVpnServiceProxy( 71 static std::unique_ptr<content::VpnServiceProxy> GetVpnServiceProxy(
72 content::BrowserContext* browser_context); 72 content::BrowserContext* browser_context);
73 73
74 static bool ShouldFrameShareParentSiteInstanceDespiteTopDocumentIsolation(
75 const GURL& url,
76 content::SiteInstance* parent_site_instance);
77
74 private: 78 private:
75 FRIEND_TEST_ALL_PREFIXES(ChromeContentBrowserClientExtensionsPartTest, 79 FRIEND_TEST_ALL_PREFIXES(ChromeContentBrowserClientExtensionsPartTest,
76 ShouldAllowOpenURLMetricsForEmptySiteURL); 80 ShouldAllowOpenURLMetricsForEmptySiteURL);
77 FRIEND_TEST_ALL_PREFIXES(ChromeContentBrowserClientExtensionsPartTest, 81 FRIEND_TEST_ALL_PREFIXES(ChromeContentBrowserClientExtensionsPartTest,
78 ShouldAllowOpenURLMetricsForKnownSchemes); 82 ShouldAllowOpenURLMetricsForKnownSchemes);
79 83
80 // Specifies reasons why web-accessible resource checks in ShouldAllowOpenURL 84 // Specifies reasons why web-accessible resource checks in ShouldAllowOpenURL
81 // might fail. 85 // might fail.
82 // 86 //
83 // This enum backs an UMA histogram. The order of existing values 87 // This enum backs an UMA histogram. The order of existing values
(...skipping 35 matching lines...) Expand 10 before | Expand all | Expand 10 after
119 Profile* profile) override; 123 Profile* profile) override;
120 void ResourceDispatcherHostCreated() override; 124 void ResourceDispatcherHostCreated() override;
121 125
122 DISALLOW_COPY_AND_ASSIGN(ChromeContentBrowserClientExtensionsPart); 126 DISALLOW_COPY_AND_ASSIGN(ChromeContentBrowserClientExtensionsPart);
123 }; 127 };
124 128
125 } // namespace extensions 129 } // namespace extensions
126 130
127 #endif // CHROME_BROWSER_EXTENSIONS_CHROME_CONTENT_BROWSER_CLIENT_EXTENSIONS_PA RT_H_ 131 #endif // CHROME_BROWSER_EXTENSIONS_CHROME_CONTENT_BROWSER_CLIENT_EXTENSIONS_PA RT_H_
128 132
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698