Add encounteredError() to AssociatedInterfacePtrController.

mojo/public/js/lib/interface_endpoint_client.js

Index: mojo/public/js/lib/interface_endpoint_client.js
diff --git a/mojo/public/js/lib/interface_endpoint_client.js b/mojo/public/js/lib/interface_endpoint_client.js
index b74b6d203acb5078adab193597d2932a667f092c..f8b7b96edbe6f0247263fcdda0858469cec70388 100644
--- a/mojo/public/js/lib/interface_endpoint_client.js
+++ b/mojo/public/js/lib/interface_endpoint_client.js
@@ -27,7 +27,7 @@ define("mojo/public/js/lib/interface_endpoint_client", [
   function InterfaceEndpointClient(interfaceEndpointHandle, receiver,
       interfaceVersion) {
     this.controller_ = null;
-    this.encounteredError_ = false;
+    this.encounteredError = false;

[Ken Rockot(use gerrit already), 2017/04/27 15:03:27]

I would prefer that we keep this value "private".

You could either add an encounteredError() function to access it, or add a
public getter property:

var getProperty = function(client) { return client.encounteredError_; };
Object.defineProperty(this, "encounteredError", getProperty.bind(this));

which would then be accessible like any other object property (i.e.,
fooClient.encounteredError), but read-only.

     this.handle_ = interfaceEndpointHandle;
     this.incomingReceiver_ = receiver;
 
@@ -99,7 +99,7 @@ define("mojo/public/js/lib/interface_endpoint_client", [
           this.handle_.groupController());
     }
 
-    if (this.encounteredError_) {
+    if (this.encounteredError) {
       return false;
     }
 
@@ -114,7 +114,7 @@ define("mojo/public/js/lib/interface_endpoint_client", [
           this.handle_.groupController());
     }
 
-    if (this.encounteredError_) {
+    if (this.encounteredError) {
       return Promise.reject();
     }
 
@@ -173,7 +173,7 @@ define("mojo/public/js/lib/interface_endpoint_client", [
       return true;
     }
 
-    if (this.encounteredError_) {
+    if (this.encounteredError) {
       return false;
     }
 
@@ -209,10 +209,10 @@ define("mojo/public/js/lib/interface_endpoint_client", [
   };
 
   InterfaceEndpointClient.prototype.notifyError = function(reason) {
-    if (this.encounteredError_) {
+    if (this.encounteredError) {
       return;
     }
-    this.encounteredError_ = true;
+    this.encounteredError = true;
 
     this.completers_.forEach(function(value) {
       value.reject();