Allow TextButton derivatives to override drawing of certain parts.

Allow TextButton derivatives to override drawing of certain parts.

This is needed for the new avatar button.
See CL https://codereview.chromium.org/240453006/ for how this will be used
to override the text rendering of the button.  Currently the new avatar menu
override the text rendering but does not do so correctly if the button has
an icon.  This change allows the new avatar menu to override the text render
more cleanly.

BUG=311235
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270858

[Roger Tawa OOO till Jul 10th, 2014-05-15 02:08:56]

Hi Scott,

Can you please take a look?  Thanks.

[sky, 2014-05-15 16:28:21]

Can you accomplish what you need by override GetTextBounds?

[Roger Tawa OOO till Jul 10th, 2014-05-15 16:46:59]

I don't think so.  See the CL mentioned in the description.  The rendering of
the text is very different.

[sky, 2014-05-15 16:55:12]

https://codereview.chromium.org/284033002/diff/40001/ui/views/controls/button...
File ui/views/controls/button/text_button.h (right):

https://codereview.chromium.org/284033002/diff/40001/ui/views/controls/button...
ui/views/controls/button/text_button.h:166: virtual void
OnPaintText(gfx::Canvas* canvas, PaintButtonMode mode);
Why is this public?

[Roger Tawa OOO till Jul 10th, 2014-05-15 17:19:27]

Thanks Scott.  Comments addressed, changes uploaded.

https://codereview.chromium.org/284033002/diff/40001/ui/views/controls/button...
File ui/views/controls/button/text_button.h (right):

https://codereview.chromium.org/284033002/diff/40001/ui/views/controls/button...
ui/views/controls/button/text_button.h:166: virtual void
OnPaintText(gfx::Canvas* canvas, PaintButtonMode mode);
On 2014/05/15 16:55:12, sky wrote:
> Why is this public?

No good reason.  Made it protected.

[sky, 2014-05-15 19:20:48]

LGTM

[Roger Tawa OOO till Jul 10th, 2014-05-15 20:25:14]

The CQ bit was checked by rogerta@chromium.org

[commit-bot: I haz the power, 2014-05-15 20:25:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rogerta@chromium.org/284033002/60001

[commit-bot: I haz the power, 2014-05-15 21:40:32]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-15 21:59:58]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-15 21:59:58]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[Roger Tawa OOO till Jul 10th, 2014-05-15 22:23:04]

The CQ bit was checked by rogerta@chromium.org

[commit-bot: I haz the power, 2014-05-15 22:24:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rogerta@chromium.org/284033002/60001

[commit-bot: I haz the power, 2014-05-15 23:49:30]

Change committed as 270858