Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(538)

Unified Diff: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py

Issue 2840273002: Fix a path through run-webkit-tests where we still aren't getting debugging. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py
diff --git a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py
index ed15115c59fb4246bc09c879000911d0e11240ea..d0c6bbd325e86c278c582898714ffe473bc9d302 100644
--- a/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py
+++ b/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/linux.py
@@ -188,6 +188,7 @@ class LinuxPort(base.Port):
_log.warn('xdpyinfo check failed with exit code %s while starting Xvfb on "%s".', exit_code, display)
self.host.sleep(0.1)
_log.fatal('Failed to start Xvfb on display "%s" (xdpyinfo check failed).', display)
+ self._stop_xvfb()
def _find_display(self):
"""Tries to find a free X display, looping if necessary."""
@@ -219,8 +220,7 @@ class LinuxPort(base.Port):
for line in self.host.filesystem.read_text_file(self._xvfb_stderr.name).splitlines():
_log.warn('Xvfb stderr: %s', line)
self.host.filesystem.remove(self._xvfb_stderr.name)
-
-
+ self._xvfb_stdout = self._xvfb_stderr = self._xvfb_process = None
def _path_to_driver(self, target=None):
binary_name = self.driver_name()
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698