third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp - Issue 2840223002: Use dark scrollbar theme for transparent frames.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

Issue 2840223002: Use dark scrollbar theme for transparent frames. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

diff --git a/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp b/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

index 551326295b5a63c2ef4c2ba4bf3cfa940c06c242..baf24c0e6797393415f903c7064d382367114486 100644

--- a/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

+++ b/third_party/WebKit/Source/platform/scroll/ScrollableArea.cpp

@@ -436,7 +436,7 @@ void ScrollableArea::RecalculateScrollbarOverlayColorTheme(

// heuristic.

double hue, saturation, lightness;

background_color.GetHSL(hue, saturation, lightness);

- if (lightness <= .5)

+ if (lightness <= .5 && background_color.Alpha())

jbroman 2017/04/26 18:10:20 Possibly the ideal threshold is a little higher th

bokan 2017/04/26 18:11:58 Yeah, I thought about that but the scrollbar theme

overlay_theme = kScrollbarOverlayColorThemeLight;

if (old_overlay_theme != overlay_theme)

« no previous file with comments | « no previous file | third_party/WebKit/Source/web/tests/ScrollbarsTest.cpp » ('j') | no next file with comments »