Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(140)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: build/secondary/third_party/android_platform/development/scripts/BUILD.gn
Issue
2840193003
:
[Android] Fix stack symbolization when packed relocations are on. (Closed)
Patch Set: tedchoc comment
Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
PRESUBMIT.py
build/android/gyp/create_stack_script.py
build/config/android/internal_rules.gni
build/config/android/rules.gni
build/print_python_deps.py
build/secondary/third_party/android_platform/development/scripts/BUILD.gn
build/secondary/third_party/android_platform/development/scripts/stack.pydeps
chrome/android/java_sources.gni
chrome/android/javatests/src/org/chromium/chrome/test/crash/IntentionalCrashTest.java
third_party/android_platform/development/scripts/stack
third_party/android_platform/development/scripts/stack_libs.py
View unified diff
|
Download patch
« no previous file with comments
|
« build/print_python_deps.py
('k') |
build/secondary/third_party/android_platform/development/scripts/stack.pydeps »
('j') |
no next file with comments »
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
(Empty)
1
# Copyright 2017 The Chromium Authors. All rights reserved.
2
# Use of this source code is governed by a BSD-style license that can be
3
# found in the LICENSE file.
4
5
group("stack_py") {
6
_py_files = read_file(
7
"//build/secondary/third_party/android_platform/development/scripts/st ack.pydeps",
8
"list lines")
9
10
set_sources_assignment_filter([ "#*" ])
11
sources = _py_files
12
data = sources
13
}
OLD
NEW
« no previous file with comments
|
« build/print_python_deps.py
('k') |
build/secondary/third_party/android_platform/development/scripts/stack.pydeps »
('j') |
no next file with comments »
Issue 2840193003: [Android] Fix stack symbolization when packed relocations are on. (Closed)
Created 3 years, 8 months ago by jbudorick
Modified 3 years, 7 months ago
Reviewers: agrieve, Ted C, Dirk Pranke
Base URL:
Comments: 7
This is Rietveld
408576698