Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Side by Side Diff: build/config/android/internal_rules.gni

Issue 2840193003: [Android] Fix stack symbolization when packed relocations are on. (Closed)
Patch Set: omitted build/secondary/third_party/android_platform/ Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # Do not add any imports to non-//build directories here. 5 # Do not add any imports to non-//build directories here.
6 # Some projects (e.g. V8) do not have non-build directories DEPS'ed in. 6 # Some projects (e.g. V8) do not have non-build directories DEPS'ed in.
7 import("//build_overrides/build.gni") 7 import("//build_overrides/build.gni")
8 import("//build/config/android/config.gni") 8 import("//build/config/android/config.gni")
9 import("//build/config/dcheck_always_on.gni") 9 import("//build/config/dcheck_always_on.gni")
10 import("//build/config/sanitizers/sanitizers.gni") 10 import("//build/config/sanitizers/sanitizers.gni")
(...skipping 618 matching lines...) Expand 10 before | Expand all | Expand 10 after
629 args += [ 629 args += [
630 "--test-runner-path", 630 "--test-runner-path",
631 android_test_runner_script, 631 android_test_runner_script,
632 ] 632 ]
633 } 633 }
634 634
635 args += test_runner_args 635 args += test_runner_args
636 } 636 }
637 } 637 }
638 638
639 template("stack_script") {
640 forward_variables_from(invoker, [ "testonly" ])
641
642 _stack_target_name = invoker.stack_target_name
643
644 action(target_name) {
645 forward_variables_from(invoker,
646 [
647 "data_deps",
648 "deps",
649 ])
650 if (!defined(deps)) {
651 deps = []
652 }
653 if (!defined(data_deps)) {
654 data_deps = []
655 }
656
657 data_deps +=
658 [ "//third_party/android_platform/development/scripts:stack_py" ]
659
660 script = "//build/android/gyp/create_stack_script.py"
661 depfile = "$target_gen_dir/$target_name.d"
662
663 stack_script = "//third_party/android_platform/development/scripts/stack"
agrieve 2017/04/26 18:19:44 nit: prefix with _
jbudorick 2017/04/26 19:34:21 Done for this and generated_script.
664
665 generated_script = "$root_build_dir/bin/stack_${_stack_target_name}"
666
667 outputs = [
668 generated_script,
669 ]
670 data = [
671 generated_script,
672 ]
673
674 args = [
675 "--depfile",
676 rebase_path(depfile, root_build_dir),
677 "--output-directory",
678 rebase_path(root_build_dir, root_build_dir),
679 "--script-path",
680 rebase_path(stack_script, root_build_dir),
681 "--script-output-path",
682 rebase_path(generated_script, root_build_dir),
683 "--arch=$target_cpu",
684 ]
685 if (defined(invoker.packed_libraries)) {
686 args += [
687 "--packed-libs",
688 invoker.packed_libraries,
689 ]
690 }
691 }
692 }
693
639 if (enable_java_templates) { 694 if (enable_java_templates) {
640 import("//build/config/zip.gni") 695 import("//build/config/zip.gni")
641 import("//third_party/ijar/ijar.gni") 696 import("//third_party/ijar/ijar.gni")
642 import("//third_party/android_platform/config.gni") 697 import("//third_party/android_platform/config.gni")
643 698
644 rebased_android_sdk = rebase_path(android_sdk, root_build_dir) 699 rebased_android_sdk = rebase_path(android_sdk, root_build_dir)
645 rebased_android_sdk_build_tools = 700 rebased_android_sdk_build_tools =
646 rebase_path(android_sdk_build_tools, root_build_dir) 701 rebase_path(android_sdk_build_tools, root_build_dir)
647 702
648 android_sdk_jar = "$android_sdk/android.jar" 703 android_sdk_jar = "$android_sdk/android.jar"
(...skipping 2141 matching lines...) Expand 10 before | Expand all | Expand 10 after
2790 rebase_path(root_build_dir, root_build_dir), 2845 rebase_path(root_build_dir, root_build_dir),
2791 "--packed-libraries-dir", 2846 "--packed-libraries-dir",
2792 rebase_path(_packed_libraries_dir, root_build_dir), 2847 rebase_path(_packed_libraries_dir, root_build_dir),
2793 "--libraries=${invoker.libraries_filearg}", 2848 "--libraries=${invoker.libraries_filearg}",
2794 "--filelistjson", 2849 "--filelistjson",
2795 rebase_path(invoker.file_list_json, root_build_dir), 2850 rebase_path(invoker.file_list_json, root_build_dir),
2796 ] 2851 ]
2797 } 2852 }
2798 } 2853 }
2799 } 2854 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698