Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(423)

Unified Diff: third_party/WebKit/Source/core/dom/NodeFilterCondition.h

Issue 2840163002: DOM: NodeIterator.filter and TreeWalker.filter should return values which were specified to createN… (Closed)
Patch Set: Move ToV8() to ToV8ForCore.h, etc. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/NodeFilterCondition.h
diff --git a/third_party/WebKit/Source/core/dom/NodeFilterCondition.h b/third_party/WebKit/Source/core/dom/NodeFilterCondition.h
index 94b12894a02d81f924c887f90d3bd2d2fb6501e5..0713daf14b42880842fa6811316b585411eac6d0 100644
--- a/third_party/WebKit/Source/core/dom/NodeFilterCondition.h
+++ b/third_party/WebKit/Source/core/dom/NodeFilterCondition.h
@@ -32,11 +32,13 @@ namespace blink {
class ExceptionState;
class Node;
+// TODO(tkent): This abstraction isn't helpful. Fold this into
+// V8NodeFilterCondition.
class NodeFilterCondition
: public GarbageCollectedFinalized<NodeFilterCondition> {
public:
virtual ~NodeFilterCondition() {}
- virtual unsigned AcceptNode(Node*, ExceptionState&) const = 0;
+ virtual unsigned acceptNode(Node*, ExceptionState&) const = 0;
DEFINE_INLINE_VIRTUAL_TRACE() {}
};
« no previous file with comments | « third_party/WebKit/Source/core/dom/NodeFilter.cpp ('k') | third_party/WebKit/Source/core/dom/NodeIterator.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698