Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp

Issue 2840163002: DOM: NodeIterator.filter and TreeWalker.filter should return values which were specified to createN… (Closed)
Patch Set: Move ToV8() to ToV8ForCore.h, etc. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_types.py ('k') | third_party/WebKit/Source/core/dom/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
diff --git a/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp b/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
index 1ac5a445fc6deb6f360440f51680051ecf01fad3..4b15cd3b5e7197ecb57de2860dea4edaf55831cf 100644
--- a/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
+++ b/third_party/WebKit/Source/bindings/tests/results/core/V8TestObject.cpp
@@ -42,7 +42,7 @@
#include "bindings/core/v8/V8Iterator.h"
#include "bindings/core/v8/V8MessagePort.h"
#include "bindings/core/v8/V8Node.h"
-#include "bindings/core/v8/V8NodeFilter.h"
+#include "bindings/core/v8/V8NodeFilterCondition.h"
#include "bindings/core/v8/V8ObjectConstructor.h"
#include "bindings/core/v8/V8PrivateProperty.h"
#include "bindings/core/v8/V8ShadowRoot.h"
@@ -780,7 +780,7 @@ static void nodeFilterAttributeAttributeGetter(const v8::FunctionCallbackInfo<v8
TestObject* impl = V8TestObject::toImpl(holder);
- V8SetReturnValueFast(info, WTF::GetPtr(impl->nodeFilterAttribute()), impl);
+ V8SetReturnValue(info, ToV8(WTF::GetPtr(impl->nodeFilterAttribute()), info.Holder(), info.GetIsolate()));
}
static void nodeFilterAttributeAttributeSetter(v8::Local<v8::Value> v8Value, const v8::FunctionCallbackInfo<v8::Value>& info) {
@@ -791,7 +791,7 @@ static void nodeFilterAttributeAttributeSetter(v8::Local<v8::Value> v8Value, con
TestObject* impl = V8TestObject::toImpl(holder);
// Prepare the value to be set.
- NodeFilter* cppValue = ToNodeFilter(v8Value, info.Holder(), ScriptState::Current(info.GetIsolate()));
+ V8NodeFilterCondition* cppValue = V8NodeFilterCondition::CreateOrNull(v8Value, ScriptState::Current(info.GetIsolate()));
impl->setNodeFilterAttribute(cppValue);
}
@@ -5592,7 +5592,7 @@ static void passPermissiveDictionaryMethodMethod(const v8::FunctionCallbackInfo<
static void nodeFilterMethodMethod(const v8::FunctionCallbackInfo<v8::Value>& info) {
TestObject* impl = V8TestObject::toImpl(info.Holder());
- V8SetReturnValue(info, impl->nodeFilterMethod());
+ V8SetReturnValue(info, ToV8(impl->nodeFilterMethod(), info.Holder(), info.GetIsolate()));
}
static void promiseMethodMethod(const v8::FunctionCallbackInfo<v8::Value>& info) {
@@ -5713,8 +5713,8 @@ static void voidMethodNodeFilterArgMethod(const v8::FunctionCallbackInfo<v8::Val
return;
}
- NodeFilter* nodeFilterArg;
- nodeFilterArg = ToNodeFilter(info[0], info.Holder(), ScriptState::Current(info.GetIsolate()));
+ V8NodeFilterCondition* nodeFilterArg;
+ nodeFilterArg = V8NodeFilterCondition::CreateOrNull(info[0], ScriptState::Current(info.GetIsolate()));
impl->voidMethodNodeFilterArg(nodeFilterArg);
}
« no previous file with comments | « third_party/WebKit/Source/bindings/scripts/v8_types.py ('k') | third_party/WebKit/Source/core/dom/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698