Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8BindingForCore.cpp

Issue 2840163002: DOM: NodeIterator.filter and TreeWalker.filter should return values which were specified to createN… (Closed)
Patch Set: Move ToV8() to ToV8ForCore.h, etc. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/bindings/core/v8/V8BindingForCore.cpp
diff --git a/third_party/WebKit/Source/bindings/core/v8/V8BindingForCore.cpp b/third_party/WebKit/Source/bindings/core/v8/V8BindingForCore.cpp
index 2e5daef3d1f1859ffe7f58526bddf7964a94cb40..fcd0503fd56f0c6fefa18b59c1a4e90573132407 100644
--- a/third_party/WebKit/Source/bindings/core/v8/V8BindingForCore.cpp
+++ b/third_party/WebKit/Source/bindings/core/v8/V8BindingForCore.cpp
@@ -37,8 +37,6 @@
#include "bindings/core/v8/V8Element.h"
#include "bindings/core/v8/V8EventTarget.h"
#include "bindings/core/v8/V8HTMLLinkElement.h"
-#include "bindings/core/v8/V8NodeFilter.h"
-#include "bindings/core/v8/V8NodeFilterCondition.h"
#include "bindings/core/v8/V8ObjectConstructor.h"
#include "bindings/core/v8/V8Window.h"
#include "bindings/core/v8/V8WorkerGlobalScope.h"
@@ -50,7 +48,6 @@
#include "core/dom/Document.h"
#include "core/dom/Element.h"
#include "core/dom/FlexibleArrayBufferView.h"
-#include "core/dom/NodeFilter.h"
#include "core/dom/QualifiedName.h"
#include "core/frame/LocalDOMWindow.h"
#include "core/frame/LocalFrame.h"
@@ -75,25 +72,6 @@
namespace blink {
-NodeFilter* ToNodeFilter(v8::Local<v8::Value> callback,
- v8::Local<v8::Object> creation_context,
- ScriptState* script_state) {
- if (callback->IsNull())
- return nullptr;
- NodeFilter* filter = NodeFilter::Create();
-
- v8::Local<v8::Value> filter_wrapper =
- ToV8(filter, creation_context, script_state->GetIsolate());
- if (filter_wrapper.IsEmpty())
- return nullptr;
-
- NodeFilterCondition* condition = V8NodeFilterCondition::Create(
- callback, filter_wrapper.As<v8::Object>(), script_state);
- filter->SetCondition(condition);
-
- return filter;
-}
-
bool ToBooleanSlow(v8::Isolate* isolate,
v8::Local<v8::Value> value,
ExceptionState& exception_state) {

Powered by Google App Engine
This is Rietveld 408576698