Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 2840163002: DOM: NodeIterator.filter and TreeWalker.filter should return values which were specified to createN… (Closed)
Patch Set: Move ToV8() to ToV8ForCore.h, etc. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2001 Dirk Mueller (mueller@kde.org) 4 * (C) 2001 Dirk Mueller (mueller@kde.org)
5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org) 5 * (C) 2006 Alexey Proskuryakov (ap@webkit.org)
6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All 6 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011, 2012 Apple Inc. All
7 * rights reserved. 7 * rights reserved.
8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. 8 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved.
9 * (http://www.torchmobile.com/) 9 * (http://www.torchmobile.com/)
10 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved. 10 * Copyright (C) 2008, 2009, 2011, 2012 Google Inc. All rights reserved.
(...skipping 1703 matching lines...) Expand 10 before | Expand all | Expand 10 after
1714 Settings* Document::GetSettings() const { 1714 Settings* Document::GetSettings() const {
1715 return frame_ ? frame_->GetSettings() : nullptr; 1715 return frame_ ? frame_->GetSettings() : nullptr;
1716 } 1716 }
1717 1717
1718 Range* Document::createRange() { 1718 Range* Document::createRange() {
1719 return Range::Create(*this); 1719 return Range::Create(*this);
1720 } 1720 }
1721 1721
1722 NodeIterator* Document::createNodeIterator(Node* root, 1722 NodeIterator* Document::createNodeIterator(Node* root,
1723 unsigned what_to_show, 1723 unsigned what_to_show,
1724 NodeFilter* filter) { 1724 V8NodeFilterCondition* filter) {
1725 DCHECK(root); 1725 DCHECK(root);
1726 return NodeIterator::Create(root, what_to_show, filter); 1726 return NodeIterator::Create(root, what_to_show, filter);
1727 } 1727 }
1728 1728
1729 TreeWalker* Document::createTreeWalker(Node* root, 1729 TreeWalker* Document::createTreeWalker(Node* root,
1730 unsigned what_to_show, 1730 unsigned what_to_show,
1731 NodeFilter* filter) { 1731 V8NodeFilterCondition* filter) {
1732 DCHECK(root); 1732 DCHECK(root);
1733 return TreeWalker::Create(root, what_to_show, filter); 1733 return TreeWalker::Create(root, what_to_show, filter);
1734 } 1734 }
1735 1735
1736 bool Document::NeedsLayoutTreeUpdate() const { 1736 bool Document::NeedsLayoutTreeUpdate() const {
1737 if (!IsActive() || !View()) 1737 if (!IsActive() || !View())
1738 return false; 1738 return false;
1739 if (NeedsFullLayoutTreeUpdate()) 1739 if (NeedsFullLayoutTreeUpdate())
1740 return true; 1740 return true;
1741 if (ChildNeedsStyleRecalc()) 1741 if (ChildNeedsStyleRecalc())
(...skipping 4993 matching lines...) Expand 10 before | Expand all | Expand 10 after
6735 } 6735 }
6736 6736
6737 void showLiveDocumentInstances() { 6737 void showLiveDocumentInstances() {
6738 WeakDocumentSet& set = liveDocumentSet(); 6738 WeakDocumentSet& set = liveDocumentSet();
6739 fprintf(stderr, "There are %u documents currently alive:\n", set.size()); 6739 fprintf(stderr, "There are %u documents currently alive:\n", set.size());
6740 for (blink::Document* document : set) 6740 for (blink::Document* document : set)
6741 fprintf(stderr, "- Document %p URL: %s\n", document, 6741 fprintf(stderr, "- Document %p URL: %s\n", document,
6742 document->Url().GetString().Utf8().data()); 6742 document->Url().GetString().Utf8().data());
6743 } 6743 }
6744 #endif 6744 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/dom/Document.h ('k') | third_party/WebKit/Source/core/dom/NodeFilter.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698