cc/trees/layer_tree_host.cc - Issue 2840143002: [cc] Change semantics of fixed-pos container layer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/trees/layer_tree_host.cc

Issue 2840143002: [cc] Change semantics of fixed-pos container layer

Patch Set: add back inner viewport container layer as fixed-pos container Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: cc/trees/layer_tree_host.cc

diff --git a/cc/trees/layer_tree_host.cc b/cc/trees/layer_tree_host.cc

index 11a354ab33e91e5fba1808882b707e6504131573..b036c21e7ce932c1e99a314b9c0044d8fbee5c9c 100644

--- a/cc/trees/layer_tree_host.cc

+++ b/cc/trees/layer_tree_host.cc

@@ -1154,7 +1154,6 @@ void LayerTreeHost::PushPropertiesTo(LayerTreeImpl* tree_impl) {

page_scale_layer_->id(), inner_viewport_scroll_layer_->id(),

outer_viewport_scroll_layer_ ? outer_viewport_scroll_layer_->id()

: Layer::INVALID_ID);

- DCHECK(inner_viewport_scroll_layer_->IsContainerForFixedPositionLayers());

} else {

tree_impl->ClearViewportLayers();

}