Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10588)

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_private_api.h

Issue 2840103002: Add new API function: feedbackPrivate.readLogSource (Closed)
Patch Set: Add comments to SingleLogSourceFactory; Add new histogram enum Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/feedback_private/feedback_private_api.h
diff --git a/chrome/browser/extensions/api/feedback_private/feedback_private_api.h b/chrome/browser/extensions/api/feedback_private/feedback_private_api.h
index 3ff94b9c3f70f5f313d42f5b347febf6d19bc50d..d2762638cdc96df95d0714b2961d796c448c5be5 100644
--- a/chrome/browser/extensions/api/feedback_private/feedback_private_api.h
+++ b/chrome/browser/extensions/api/feedback_private/feedback_private_api.h
@@ -12,6 +12,11 @@
#include "extensions/browser/extension_function.h"
#include "ui/gfx/geometry/rect.h"
+#if defined(OS_CHROMEOS)
+#include "base/time/time.h"
+#include "chrome/browser/extensions/api/feedback_private/log_source_access_manager.h"
+#endif // defined(OS_CHROMEOS)
+
namespace extensions {
class FeedbackService;
@@ -23,6 +28,10 @@ class FeedbackPrivateAPI : public BrowserContextKeyedAPI {
FeedbackService* GetService() const;
+#if defined(OS_CHROMEOS)
+ LogSourceAccessManager* GetLogSourceAccessManager() { return &manager_; }
+#endif // defined(OS_CHROMEOS)
+
void RequestFeedback(const std::string& description_template,
const std::string& category_tag,
const GURL& page_url);
@@ -48,6 +57,9 @@ class FeedbackPrivateAPI : public BrowserContextKeyedAPI {
content::BrowserContext* const browser_context_;
FeedbackService* service_;
+#if defined(OS_CHROMEOS)
+ LogSourceAccessManager manager_;
+#endif // defined(OS_CHROMEOS)
};
// Feedback strings.
@@ -95,6 +107,40 @@ class FeedbackPrivateGetSystemInformationFunction
void OnCompleted(std::unique_ptr<system_logs::SystemLogsResponse> sys_info);
};
+// This function only reads from actual log sources on Chrome OS. On other
+// platforms, it just returns EmptyResponse().
+class FeedbackPrivateReadLogSourceFunction : public UIThreadExtensionFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION("feedbackPrivate.readLogSource",
+ FEEDBACKPRIVATE_READLOGSOURCE);
+
+#if defined(OS_CHROMEOS)
+ // To override the default rate-limiting mechanism of this function, pass in
+ // a TimeDelta representing the desired minimum time between consecutive reads
+ // of a source from an extension. Does not take ownership of |timeout|. When
+ // done testing, call this function again with |timeout|=nullptr to reset to
+ // the default behavior.
+ static void SetRateLimitingTimeoutForTesting(const base::TimeDelta* timeout);
+#endif // defined(OS_CHROMEOS)
+
+ protected:
+ ~FeedbackPrivateReadLogSourceFunction() override {}
+ ResponseAction Run() override;
+
+ private:
+ // Returns a default response to the API that contains no data. Return this
+ // from Run() when it hits an error case and needs to return early, or on
+ // platforms where the ReadLogSource capability is not supported.
+ ResponseAction EmptyResponse();
+
+#if defined(OS_CHROMEOS)
+ void OnCompleted(api::feedback_private::LogSource source,
+ int readerId,
+ bool incremental,
+ system_logs::SystemLogsResponse* response);
+#endif // defined(OS_CHROMEOS)
+};
+
class FeedbackPrivateSendFeedbackFunction
: public ChromeAsyncExtensionFunction {
public:

Powered by Google App Engine
This is Rietveld 408576698