Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2887)

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_private_api.h

Issue 2840103002: Add new API function: feedbackPrivate.readLogSource (Closed)
Patch Set: Add proper ifdefs for non-CrOS platforms Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/feedback_private/feedback_private_api.h
diff --git a/chrome/browser/extensions/api/feedback_private/feedback_private_api.h b/chrome/browser/extensions/api/feedback_private/feedback_private_api.h
index e3a30074fcb3305b20c1d2be9d5531ed29bcf316..b993acb6da01fc62367940708b2cad26fc491417 100644
--- a/chrome/browser/extensions/api/feedback_private/feedback_private_api.h
+++ b/chrome/browser/extensions/api/feedback_private/feedback_private_api.h
@@ -5,6 +5,8 @@
#ifndef CHROME_BROWSER_EXTENSIONS_API_FEEDBACK_PRIVATE_FEEDBACK_PRIVATE_API_H_
#define CHROME_BROWSER_EXTENSIONS_API_FEEDBACK_PRIVATE_FEEDBACK_PRIVATE_API_H_
+#include <memory>
+
#include "chrome/browser/extensions/chrome_extension_function.h"
#include "chrome/browser/feedback/system_logs/system_logs_fetcher.h"
#include "chrome/common/extensions/api/feedback_private.h"
@@ -15,6 +17,9 @@
namespace extensions {
class FeedbackService;
+#if defined(OS_CHROMEOS)
+class LogSourceAccessManager;
+#endif // defined(OS_CHROMEOS)
class FeedbackPrivateAPI : public BrowserContextKeyedAPI {
public:
@@ -23,6 +28,10 @@ class FeedbackPrivateAPI : public BrowserContextKeyedAPI {
FeedbackService* GetService() const;
+#if defined(OS_CHROMEOS)
+ LogSourceAccessManager* GetLogSourceAccessManager() const;
+#endif // defined(OS_CHROMEOS)
+
void RequestFeedback(const std::string& description_template,
const std::string& category_tag,
const GURL& page_url);
@@ -47,7 +56,13 @@ class FeedbackPrivateAPI : public BrowserContextKeyedAPI {
static const bool kServiceHasOwnInstanceInIncognito = true;
content::BrowserContext* const browser_context_;
- FeedbackService* service_;
+ std::unique_ptr<FeedbackService> service_;
+
+#if defined(OS_CHROMEOS)
+ std::unique_ptr<LogSourceAccessManager> log_source_access_manager_;
+#endif // defined(OS_CHROMEOS)
+
+ DISALLOW_COPY_AND_ASSIGN(FeedbackPrivateAPI);
};
// Feedback strings.
@@ -95,6 +110,23 @@ class FeedbackPrivateGetSystemInformationFunction
void OnCompleted(std::unique_ptr<system_logs::SystemLogsResponse> sys_info);
};
+// This function only reads from actual log sources on Chrome OS. On other
+// platforms, it just returns EmptyResponse().
+class FeedbackPrivateReadLogSourceFunction : public UIThreadExtensionFunction {
+ public:
+ DECLARE_EXTENSION_FUNCTION("feedbackPrivate.readLogSource",
+ FEEDBACKPRIVATE_READLOGSOURCE);
+
+ protected:
+ ~FeedbackPrivateReadLogSourceFunction() override {}
+ ResponseAction Run() override;
+
+#if defined(OS_CHROMEOS)
+ private:
+ void OnCompleted(const api::feedback_private::ReadLogSourceResult& result);
+#endif // defined(OS_CHROMEOS)
+};
+
class FeedbackPrivateSendFeedbackFunction
: public ChromeAsyncExtensionFunction {
public:
« no previous file with comments | « chrome/browser/extensions/BUILD.gn ('k') | chrome/browser/extensions/api/feedback_private/feedback_private_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698