Add new API function: feedbackPrivate.readLogSource

chrome/browser/extensions/api/feedback_private/log_source_resource.cc

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/api/feedback_private/log_source_resource.h"
+
+#include "base/lazy_instance.h"
+
+namespace extensions {
+
+// For managing API resources of type LogSourceResource.
+static base::LazyInstance<BrowserContextKeyedAPIFactory<
+    ApiResourceManager<LogSourceResource>>>::DestructorAtExit

[tbarzic, 2017/06/06 20:27:26]

Can this be leaky instead?
(see
https://cs.chromium.org/chromium/src/base/lazy_instance.h?rcl=66008232510835b...)

[Simon Que, 2017/06/06 22:29:15]

It doesn't work, results in a crash.

DestructorAtExit is used in other instances of ApiResourceManager too, e.g.:
https://cs.chromium.org/chromium/src/extensions/browser/api/socket/tcp_socket.cc

+    g_log_source_resource_factory = LAZY_INSTANCE_INITIALIZER;
+
+// static
+template <>
+BrowserContextKeyedAPIFactory<ApiResourceManager<LogSourceResource>>*
+ApiResourceManager<LogSourceResource>::GetFactoryInstance() {
+  return g_log_source_resource_factory.Pointer();
+}
+
+LogSourceResource::LogSourceResource(
+    const std::string& extension_id,
+    std::unique_ptr<system_logs::SingleLogSource> source,
+    base::Closure unregister_callback)
+    : ApiResource(extension_id),
+      source_(source.release()),
+      unregister_runner_(unregister_callback) {}
+
+LogSourceResource::~LogSourceResource() {}
+
+}  // namespace extensions