Add new API function: feedbackPrivate.readLogSource

chrome/browser/extensions/api/feedback_private/feedback_private_api.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_EXTENSIONS_API_FEEDBACK_PRIVATE_FEEDBACK_PRIVATE_API_H_
 #define CHROME_BROWSER_EXTENSIONS_API_FEEDBACK_PRIVATE_FEEDBACK_PRIVATE_API_H_
 
+#include <memory>
+
 #include "chrome/browser/extensions/chrome_extension_function.h"
 #include "chrome/browser/feedback/system_logs/system_logs_fetcher_base.h"
 #include "chrome/common/extensions/api/feedback_private.h"
 #include "extensions/browser/browser_context_keyed_api_factory.h"
 #include "extensions/browser/extension_function.h"
 #include "ui/gfx/geometry/rect.h"
 
+#if defined(OS_CHROMEOS)
+#include "base/time/time.h"

[tbarzic, 2017/06/06 20:27:25]

nit: can you clean these up.

[Simon Que, 2017/06/06 22:29:14]

Done.

+#include "chrome/browser/chromeos/system_logs/single_log_source.h"
+#include "chrome/browser/extensions/api/feedback_private/log_source_access_manager.h"

[tbarzic, 2017/06/06 20:27:25]

nit: you can forward declare this one

[Simon Que, 2017/06/06 22:29:14]

Done.

+#endif  // defined(OS_CHROMEOS)
+
 namespace extensions {
 
 class FeedbackService;
 
 class FeedbackPrivateAPI : public BrowserContextKeyedAPI {
  public:
   explicit FeedbackPrivateAPI(content::BrowserContext* context);
   ~FeedbackPrivateAPI() override;
 
   FeedbackService* GetService() const;
 
+#if defined(OS_CHROMEOS)
+  LogSourceAccessManager* log_source_access_manager() const {
+    return log_source_access_manager_.get();

[tbarzic, 2017/06/06 20:27:25]

nit: can rename this to GetLockSourceAcceeManager (to be consistent with
GetService).

(or maybe do it other way around, rename GetService to service() const, and
inline it here)

[Simon Que, 2017/06/06 22:29:14]

Done.

+  }
+#endif  // defined(OS_CHROMEOS)
+
   void RequestFeedback(const std::string& description_template,
                        const std::string& category_tag,
                        const GURL& page_url);
 
   void RequestFeedbackForFlow(const std::string& description_template,
                               const std::string& category_tag,
                               const GURL& page_url,
                               api::feedback_private::FeedbackFlow flow);
 
   // BrowserContextKeyedAPI implementation.
   static BrowserContextKeyedAPIFactory<FeedbackPrivateAPI>*
       GetFactoryInstance();
 
  private:
   friend class BrowserContextKeyedAPIFactory<FeedbackPrivateAPI>;
 
   // BrowserContextKeyedAPI implementation.
   static const char* service_name() {
     return "FeedbackPrivateAPI";
   }
 
   static const bool kServiceHasOwnInstanceInIncognito = true;
 
   content::BrowserContext* const browser_context_;
-  FeedbackService* service_;
+  std::unique_ptr<FeedbackService> service_;
+
+#if defined(OS_CHROMEOS)
+  std::unique_ptr<LogSourceAccessManager> log_source_access_manager_;
+#endif  // defined(OS_CHROMEOS)
 };
 
 // Feedback strings.
 class FeedbackPrivateGetStringsFunction : public UIThreadExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("feedbackPrivate.getStrings",
                              FEEDBACKPRIVATE_GETSTRINGS)
 
   // Invoke this callback when this function is called - used for testing.
   static void set_test_callback(base::Closure* const callback) {
@@ skipping 27 matching lines @@
                              FEEDBACKPRIVATE_GETSYSTEMINFORMATION);
 
  protected:
   ~FeedbackPrivateGetSystemInformationFunction() override {}
   ResponseAction Run() override;
 
  private:
   void OnCompleted(std::unique_ptr<system_logs::SystemLogsResponse> sys_info);
 };
 
+// This function only reads from actual log sources on Chrome OS. On other
+// platforms, it just returns EmptyResponse().
+class FeedbackPrivateReadLogSourceFunction : public UIThreadExtensionFunction {
+ public:
+  DECLARE_EXTENSION_FUNCTION("feedbackPrivate.readLogSource",
+                             FEEDBACKPRIVATE_READLOGSOURCE);
+
+ protected:
+  ~FeedbackPrivateReadLogSourceFunction() override {}
+  ResponseAction Run() override;
+
+#if defined(OS_CHROMEOS)
+ private:
+  void OnCompleted(api::feedback_private::ReadLogSourceResult& result);
+#endif  // defined(OS_CHROMEOS)
+};
+
 class FeedbackPrivateSendFeedbackFunction
     : public ChromeAsyncExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("feedbackPrivate.sendFeedback",
                              FEEDBACKPRIVATE_SENDFEEDBACK);
 
  protected:
   ~FeedbackPrivateSendFeedbackFunction() override {}
   bool RunAsync() override;
 
  private:
   void OnCompleted(bool success);
 };
 
 class FeedbackPrivateLogSrtPromptResultFunction
     : public UIThreadExtensionFunction {
  public:
   DECLARE_EXTENSION_FUNCTION("feedbackPrivate.logSrtPromptResult",
                              FEEDBACKPRIVATE_LOGSRTPROMPTRESULT);
 
  protected:
   ~FeedbackPrivateLogSrtPromptResultFunction() override {}
   AsyncExtensionFunction::ResponseAction Run() override;
 };
 
 }  // namespace extensions
 
 #endif  // CHROME_BROWSER_EXTENSIONS_API_FEEDBACK_PRIVATE_FEEDBACK_PRIVATE_API_H_