Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1159)

Unified Diff: appengine/components/components/auth/ui/templates/base.html

Issue 2840053003: auth_service: Fetch revisions of all configs (for UI) at once. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/components/components/auth/ui/templates/base.html
diff --git a/appengine/components/components/auth/ui/templates/base.html b/appengine/components/components/auth/ui/templates/base.html
index b5407fad614a1ade83c4226b1ba3ce76edb176b4..928ae59110b585b1a67fa10d70e116d9d2e78ea4 100644
--- a/appengine/components/components/auth/ui/templates/base.html
+++ b/appengine/components/components/auth/ui/templates/base.html
@@ -46,13 +46,14 @@ that can be found in the LICENSE file. -->
{% endraw %}
{# Used on auth_service if config_service is managing configs #}
Vadim Sh. 2017/04/25 23:17:40 note: this will be done in Javascript later
-{% macro render_config_locked() -%}
+{% macro render_config_locked(config_path) -%}
+{% set rev = auth_service_config_revisions[config_path] %}
nodir 2017/04/28 17:49:24 I think this is config, not rev. `cfg`?
Vadim Sh. 2017/04/29 01:59:10 This specifies SHA1 of the config commit and an UR
<hr>
<p>
The configuration is distributed by
<a target="_blank" href="{{auth_service_config_remote_url}}">luci-config</a>.
-Using revision <a target="_blank" href="{{auth_service_config_url}}"
-style="font-family:monospace;">{{auth_service_config_rev}}</a>.
+Using revision <a target="_blank" href="{{rev['url']}}"
+style="font-family:monospace;">{{rev['rev']}}</a>.
</p>
{%- endmacro %}

Powered by Google App Engine
This is Rietveld 408576698