Fix for broken "Load unpacked extension" popup

chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos.cc

Index: chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos.cc
diff --git a/chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos.cc b/chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos.cc
index 28af4c8469ba2a3acf05fc87be106e56fc9c6ea0..f6ac7f4c20f108f6740f56a591de3e9bb6c8e53d 100644
--- a/chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos.cc
+++ b/chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos.cc
@@ -32,11 +32,12 @@ void PermissionsUpdaterDelegateChromeOS::InitializePermissions(
   // clipboard read functionality). This forceful removal of permission is safe
   // since the clipboard pasting code checks for this permission before doing
   // the paste (the end result is just an empty paste).
-  APIPermissionSet api_permission_set((*granted_permissions)->apis());
-  api_permission_set.erase(APIPermission::kClipboardRead);
-  granted_permissions->reset(
-      new PermissionSet(api_permission_set, ManifestPermissionSet(),
-                        URLPatternSet(), URLPatternSet()));
+  APIPermissionSet api_permission_set;
+  api_permission_set.insert(APIPermission::kClipboardRead);
+  *granted_permissions = PermissionSet::CreateDifference(

[Ivan Šandrk, 2017/04/26 13:25:02]

Does this approach seem better? Maybe a bit less prone to missing something, as
we need to explicitly remove what we don't want.

[Devlin, 2017/04/26 14:58:26]

yep, this looks better.  Good idea!

+      **granted_permissions,
+      PermissionSet(api_permission_set, ManifestPermissionSet(),
+                    URLPatternSet(), URLPatternSet()));
 }
 
 }  // namespace extensions