Fix for broken "Load unpacked extension" popup

chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/extensions/permissions_updater_delegate_chromeos.h"
 
 #include "chrome/browser/chromeos/extensions/device_local_account_management_policy_provider.h"
 #include "chrome/browser/profiles/profiles_state.h"
 #include "extensions/common/permissions/api_permission.h"
 #include "extensions/common/permissions/api_permission_set.h"
@@ skipping 16 matching lines @@
       !(*granted_permissions)
            ->HasAPIPermission(APIPermission::kClipboardRead)) {
     return;
   }
   // Revoke kClipboardRead permission (used in Public Sessions to secure
   // clipboard read functionality). This forceful removal of permission is safe
   // since the clipboard pasting code checks for this permission before doing
   // the paste (the end result is just an empty paste).
   APIPermissionSet api_permission_set((*granted_permissions)->apis());
   api_permission_set.erase(APIPermission::kClipboardRead);
-  granted_permissions->reset(
-      new PermissionSet(api_permission_set, ManifestPermissionSet(),
-                        URLPatternSet(), URLPatternSet()));
+  granted_permissions->reset(new PermissionSet(
+      api_permission_set, (*granted_permissions)->manifest_permissions(),

[Ivan Šandrk, 2017/04/25 18:51:59]

Should I maybe have a temporary helper variable to shorten the following?:

(*granted_permissions)->...

[Devlin, 2017/04/25 18:57:48]

I'd say it's probably not worth it, since this is resetting the granted
permissions, so a variable set to the old value would become unsafe very soon. 
But, if you wanted to, you could scope it, e.g.
api_permission_set.erase(APIPermission::kClipboardRead);
{
  const PermissionSet& granted = *granted_permissions;
  granted_permissions = base::MakeUnique<PermissionSet>(
      api_permission_set, granted.manifest_permissions(),
      granted.explicit_hosts(), granted.scriptable_hosts()));
}

which would discourage its unsafe use and would be okay.

[Ivan Šandrk, 2017/04/25 19:42:11]

I guess it's not worth the bother.

+      (*granted_permissions)->explicit_hosts(),
+      (*granted_permissions)->scriptable_hosts()));
 }
 
 }  // namespace extensions