This is also failing on Valgrind.

This is also failing on Valgrind.

16 bytes in 1 blocks are definitely lost in loss record 395 of 765
  operator new(unsigned int) (sr/local/google/valgrind-for-chromium-client/valgrind/scripts/valgrind-memcheck/coregrind/m_replacemalloc/vg_replace_malloc.c:262)
  Callback3<remoting::UpdateStreamPacketHeader const*, scoped_refptr<media::DataBuffer> const&, int>::Type* NewCallback<remoting::SessionManager, remoting::UpdateStreamPacketHeader const*, scoped_refptr<media::DataBuffer> const&, int>(remoting::SessionManager*, void (remoting::SessionManager::*)(remoting::UpdateStreamPacketHeader const*, scoped_refptr<media::DataBuffer> const&, int)) (uilder/build/src/./base/callback.h:169)
  remoting::SessionManager::DoEncode(scoped_refptr<remoting::Capturer::CaptureData>) (uilder/build/src/remoting/host/session_manager.cc:206)
  void DispatchToMethod<remoting::SessionManager, void (remoting::SessionManager::*)(scoped_refptr<remoting::Capturer::CaptureData>), scoped_refptr<remoting::Capturer::CaptureData> >(remoting::SessionManager*, void (remoting::SessionManager::*)(scoped_refptr<remoting::Capturer::CaptureData>), Tuple1<scoped_refptr<remoting::Capturer::CaptureData> > const&) (uilder/build/src/./base/tuple.h:422)
  RunnableMethod<remoting::SessionManager, void (remoting::SessionManager::*)(scoped_refptr<remoting::Capturer::CaptureData>), Tuple1<scoped_refptr<remoting::Capturer::CaptureData> > >::Run() (uilder/build/src/./base/task.h:323)
  MessageLoop::RunTask(Task*) (uilder/build/src/base/message_loop.cc:366)
  MessageLoop::DeferOrRunPendingTask(MessageLoop::PendingTask const&) (uilder/build/src/base/message_loop.cc:375)
  MessageLoop::DoWork() (uilder/build/src/base/message_loop.cc:482)
  base::MessagePumpDefault::Run(base::MessagePump::Delegate*) (uilder/build/src/base/message_pump_default.cc:23)
  MessageLoop::RunInternal() (uilder/build/src/base/message_loop.cc:214)
  MessageLoop::RunHandler() (uilder/build/src/base/message_loop.cc:186)
  MessageLoop::RunAllPending() (uilder/build/src/base/message_loop.cc:170)
  remoting::SessionManagerTest_OneRecordCycle_Test::TestBody() (uilder/build/src/remoting/host/session_manager_unittest.cc:133)
  testing::Test::Run() (uilder/build/src/testing/gtest/src/gtest.cc:2095)
  testing::internal::TestInfoImpl::Run() (uilder/build/src/testing/gtest/src/gtest.cc:2314)
  testing::TestCase::Run() (uilder/build/src/testing/gtest/src/gtest.cc:2420)
  testing::internal::UnitTestImpl::RunAllTests() (uilder/build/src/testing/gtest/src/gtest.cc:4024)
  testing::UnitTest::Run() (uilder/build/src/testing/gtest/src/gtest.cc:3687)
  TestSuite::Run() (uilder/build/src/./base/test/test_suite.h:150)
  main (uilder/build/src/remoting/run_all_unittests.cc:8)


BUG=46678
TEST=green bots

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=51569

[Lei Zhang, 2010-07-02 22:11:30]

LGTM, but the commit message could use more details.