Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Issue 284003002: NULL out pending_requests_ when GPU channel fails to be created. (Closed)

Created:
6 years, 7 months ago by jbauman
Modified:
6 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org, jam, darin-cc_chromium.org, Ken Russell (switch to Gerrit)
Visibility:
Public.

Description

NULL out pending_requests_ when GPU channel fails to be created. Otherwise the next attempt to create a GPU channel won't create a new pending request and will hang forever. BUG=365904 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270594

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M content/browser/gpu/browser_gpu_channel_host_factory.cc View 1 1 chunk +9 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
jbauman
6 years, 7 months ago (2014-05-14 18:11:21 UTC) #1
piman
lgtm https://codereview.chromium.org/284003002/diff/1/content/browser/gpu/browser_gpu_channel_host_factory.cc File content/browser/gpu/browser_gpu_channel_host_factory.cc (right): https://codereview.chromium.org/284003002/diff/1/content/browser/gpu/browser_gpu_channel_host_factory.cc#newcode362 content/browser/gpu/browser_gpu_channel_host_factory.cc:362: gpu_channel_ = NULL; nit: gpu_channel_ should be NULL ...
6 years, 7 months ago (2014-05-14 19:08:17 UTC) #2
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 7 months ago (2014-05-14 21:17:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/284003002/20001
6 years, 7 months ago (2014-05-14 21:19:13 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-15 00:51:03 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-15 06:11:01 UTC) #6
Message was sent while issue was closed.
Change committed as 270594

Powered by Google App Engine
This is Rietveld 408576698