Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(155)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2839993002: [Android] Adding Smart GO/NEXT feature in Chrome (Closed)
Patch Set: Moved the Focus movement logic from IMC to FocusController and addressed other review comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index 6455f6300308540d11a0cd5f6970fcd758c24bc8..ae60e04c1fbe8443a35508551f49b57cc1b6b636 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -2571,6 +2571,22 @@ void WebLocalFrameImpl::ExtractSmartClipData(WebRect rect_in_viewport,
}
}
+void WebLocalFrameImpl::AdvanceFocusInForm(WebFocusType focusType) {
+ DCHECK(GetFrame()->GetDocument());
+ Element* element = GetFrame()->GetDocument()->FocusedElement();
+ if (!element)
+ return;
+
+ Element* next_element =
+ GetFrame()->GetPage()->GetFocusController().NextFocusableElementInForm(
+ element, focusType);
+ if (!next_element)
+ return;
+
+ next_element->scrollIntoViewIfNeeded(true /*centerIfNeeded*/);
+ next_element->focus();
+}
+
TextCheckerClient& WebLocalFrameImpl::GetTextCheckerClient() const {
return *text_checker_client_;
}

Powered by Google App Engine
This is Rietveld 408576698