Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/Source/web/tests/WebViewTest.cpp

Issue 2839993002: [Android] Adding Smart GO/NEXT feature in Chrome (Closed)
Patch Set: Rebased the patch along with review comment fixes. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/tests/WebViewTest.cpp
diff --git a/third_party/WebKit/Source/web/tests/WebViewTest.cpp b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
index 928873af3bf212dc4014f0cea330b83321fc4050..4a41f81b7b4c1279bd32a684b3ed65d731c9d10b 100644
--- a/third_party/WebKit/Source/web/tests/WebViewTest.cpp
+++ b/third_party/WebKit/Source/web/tests/WebViewTest.cpp
@@ -1624,6 +1624,364 @@ TEST_P(WebViewTest, IsSelectionAnchorFirst) {
EXPECT_FALSE(web_view->IsSelectionAnchorFirst());
}
+TEST_P(
+ WebViewTest,
+ MoveFocusToNextFocusableElementInFormWithKeyEventListenersAndNonEditableElements) {
+ const std::string testFile =
+ "advance_focus_in_form_with_key_event_listeners.html";
+ RegisterMockedHttpURLLoad(testFile);
+ WebViewImpl* webViewImpl =
+ web_view_helper_.InitializeAndLoad(base_url_ + testFile);
+ webViewImpl->SetInitialFocus(false);
+ Document* document = webViewImpl->MainFrameImpl()->GetFrame()->GetDocument();
+ WebInputMethodController* activeInputMethodController =
+ webViewImpl->MainFrameImpl()
+ ->FrameWidget()
+ ->GetActiveWebInputMethodController();
+ const int defaultTextInputFlags = kWebTextInputFlagAutocapitalizeSentences;
+
+ struct FocusedElement {
+ const char* elementId;
+ int textInputFlags;
+ } focusedElements[] = {
+ {"input1",
+ defaultTextInputFlags | kWebTextInputFlagHaveNextFocusableElement},
+ {"contenteditable1", kWebTextInputFlagHaveNextFocusableElement |
+ kWebTextInputFlagHavePreviousFocusableElement},
+ {"input2", defaultTextInputFlags |
+ kWebTextInputFlagHaveNextFocusableElement |
+ kWebTextInputFlagHavePreviousFocusableElement |
+ kWebTextInputFlagListeningToKeyboardEvents},
+ {"textarea1", defaultTextInputFlags |
+ kWebTextInputFlagHaveNextFocusableElement |
+ kWebTextInputFlagHavePreviousFocusableElement},
+ {"input3", defaultTextInputFlags |
+ kWebTextInputFlagHaveNextFocusableElement |
+ kWebTextInputFlagHavePreviousFocusableElement},
+ {"textarea2",
+ defaultTextInputFlags | kWebTextInputFlagHavePreviousFocusableElement},
+ };
+
+ // Forward Navigation in form1 with NEXT
+ Element* input1 = document->getElementById("input1");
+ input1->focus();
+ Element* currentFocus = nullptr;
+ WebTextInputInfo textInputInfo;
+ for (size_t i = 0; i < WTF_ARRAY_LENGTH(focusedElements); ++i) {
+ currentFocus = document->getElementById(focusedElements[i].elementId);
+ EXPECT_EQ(currentFocus, document->FocusedElement());
+ textInputInfo = activeInputMethodController->TextInputInfo();
+ EXPECT_EQ(focusedElements[i].textInputFlags, textInputInfo.flags);
+ webViewImpl->MainFrameImpl()->AdvanceFocusInForm(kWebFocusTypeForward);
+ }
+ // Now focus will stay on previous focus itself, because it has no next
+ // element.
+ EXPECT_EQ(currentFocus, document->FocusedElement());
+
+ // Backward Navigation in form1 with PREVIOUS
+ for (size_t i = WTF_ARRAY_LENGTH(focusedElements); i-- > 0;) {
+ currentFocus = document->getElementById(focusedElements[i].elementId);
+ EXPECT_EQ(currentFocus, document->FocusedElement());
+ textInputInfo = activeInputMethodController->TextInputInfo();
+ EXPECT_EQ(focusedElements[i].textInputFlags, textInputInfo.flags);
+ webViewImpl->MainFrameImpl()->AdvanceFocusInForm(kWebFocusTypeBackward);
+ }
+ // Now focus will stay on previous focus itself, because it has no previous
+ // element.
+ EXPECT_EQ(currentFocus, document->FocusedElement());
+
+ // Setting a non editable element as focus in form1, and ensuring editable
+ // navigation is fine in forward and backward.
+ Element* button1 = document->getElementById("button1");
+ button1->focus();
+ textInputInfo = activeInputMethodController->TextInputInfo();
+ // No Next/Previous element for elements outside form.
+ EXPECT_EQ(0, textInputInfo.flags);
+ webViewImpl->MainFrameImpl()->AdvanceFocusInForm(kWebFocusTypeForward);
+ Element* contenteditable1 = document->getElementById("contenteditable1");
+ EXPECT_EQ(contenteditable1, document->FocusedElement());
+ button1->focus();
+ webViewImpl->MainFrameImpl()->AdvanceFocusInForm(kWebFocusTypeBackward);
+ EXPECT_EQ(input1, document->FocusedElement());
+
+ Element* anchor1 = document->getElementById("anchor1");
+ anchor1->focus();
+ textInputInfo = activeInputMethodController->TextInputInfo();
+ // No Next/Previous element for elements outside form.
+ EXPECT_EQ(0, textInputInfo.flags);
+ webViewImpl->MainFrameImpl()->AdvanceFocusInForm(kWebFocusTypeForward);
+ // Since anchor is not a form control element, next/previous element will
+ // be null, hence focus will stay same as it is.
+ EXPECT_EQ(anchor1, document->FocusedElement());
+ webViewImpl->MainFrameImpl()->AdvanceFocusInForm(kWebFocusTypeBackward);
+ EXPECT_EQ(anchor1, document->FocusedElement());
+
+ // Navigation of elements which is not part of any forms.
+ Element* textarea3 = document->getElementById("textarea3");
+ textarea3->focus();
+ textInputInfo = activeInputMethodController->TextInputInfo();
+ // No Next/Previous element for elements outside form.
+ EXPECT_EQ(defaultTextInputFlags, textInputInfo.flags);
+ webViewImpl->MainFrameImpl()->AdvanceFocusInForm(kWebFocusTypeForward);
+ // No Next/Previous element to this element because it's not part of any
+ // form. Hence focus won't change wrt NEXT/PREVIOUS.
+ EXPECT_EQ(textarea3, document->FocusedElement());
+ webViewImpl->MainFrameImpl()->AdvanceFocusInForm(kWebFocusTypeBackward);
+ EXPECT_EQ(textarea3, document->FocusedElement());
+
+ // Navigation from an element which is part of a form but not an editable
+ // element.
+ Element* button2 = document->getElementById("button2");
+ button2->focus();
+ textInputInfo = activeInputMethodController->TextInputInfo();
+ // No Next element for this element, due to last element outside the form.
+ EXPECT_EQ(0, textInputInfo.flags);
+ webViewImpl->MainFrameImpl()->AdvanceFocusInForm(kWebFocusTypeForward);
+ // No Next element to this element because it's not part of any form.
+ // Hence focus won't change wrt NEXT.
+ EXPECT_EQ(button2, document->FocusedElement());
+ webViewImpl->MainFrameImpl()->AdvanceFocusInForm(kWebFocusTypeBackward);
+ // Since button is a form control element from form1, ensuring focus is set
+ // at correct position.
+ Element* textarea2 = document->getElementById("textarea2");
+ EXPECT_EQ(textarea2, document->FocusedElement());
+
+ Element* contenteditable2 = document->getElementById("contenteditable2");
+ document->SetFocusedElement(
+ contenteditable2,
+ FocusParams(SelectionBehaviorOnFocus::kNone, kWebFocusTypeNone, nullptr));
+ textInputInfo = activeInputMethodController->TextInputInfo();
+ // No Next/Previous element for elements outside form.
+ EXPECT_EQ(0, textInputInfo.flags);
+ webViewImpl->MainFrameImpl()->AdvanceFocusInForm(kWebFocusTypeForward);
+ // No Next/Previous element to this element because it's not part of any
+ // form. Hence focus won't change wrt NEXT/PREVIOUS.
+ EXPECT_EQ(contenteditable2, document->FocusedElement());
+ webViewImpl->MainFrameImpl()->AdvanceFocusInForm(kWebFocusTypeBackward);
+ EXPECT_EQ(contenteditable2, document->FocusedElement());
+
+ // Navigation of elements which is having invalid form attribute and hence
+ // not part of any forms.
+ Element* textarea4 = document->getElementById("textarea4");
+ textarea4->focus();
+ textInputInfo = activeInputMethodController->TextInputInfo();
+ // No Next/Previous element for elements which is having invalid form
+ // attribute.
+ EXPECT_EQ(defaultTextInputFlags, textInputInfo.flags);
+ webViewImpl->MainFrameImpl()->AdvanceFocusInForm(kWebFocusTypeForward);
+ // No Next/Previous element to this element because it's not part of any
+ // form. Hence focus won't change wrt NEXT/PREVIOUS.
+ EXPECT_EQ(textarea4, document->FocusedElement());
+ webViewImpl->MainFrameImpl()->AdvanceFocusInForm(kWebFocusTypeBackward);
+ EXPECT_EQ(textarea4, document->FocusedElement());
+
+ web_view_helper_.Reset();
+}
+
+TEST_P(
+ WebViewTest,
+ MoveFocusToNextFocusableElementInFormWithNonEditableNonFormControlElements) {
+ const std::string testFile =
+ "advance_focus_in_form_with_key_event_listeners.html";
+ RegisterMockedHttpURLLoad(testFile);
+ WebViewImpl* webViewImpl =
+ web_view_helper_.InitializeAndLoad(base_url_ + testFile);
+ webViewImpl->SetInitialFocus(false);
+ Document* document = webViewImpl->MainFrameImpl()->GetFrame()->GetDocument();
+ WebInputMethodController* activeInputMethodController =
+ webViewImpl->MainFrameImpl()
+ ->FrameWidget()
+ ->GetActiveWebInputMethodController();
+ const int defaultTextInputFlags = kWebTextInputFlagAutocapitalizeSentences;
+
+ struct FocusedElement {
+ const char* elementId;
+ int textInputFlags;
+ } focusedElements[] = {
+ {"textarea5", defaultTextInputFlags |
+ kWebTextInputFlagListeningToKeyboardEvents |
+ kWebTextInputFlagHaveNextFocusableElement},
+ {"input4", defaultTextInputFlags |
+ kWebTextInputFlagListeningToKeyboardEvents |
+ kWebTextInputFlagHaveNextFocusableElement |
+ kWebTextInputFlagHavePreviousFocusableElement},
+ {"contenteditable3", kWebTextInputFlagListeningToKeyboardEvents |
+ kWebTextInputFlagHavePreviousFocusableElement},
+ };
+
+ // Forward Navigation in form2 with NEXT
+ Element* textarea5 = document->getElementById("textarea5");
+ textarea5->focus();
+ Element* currentFocus = nullptr;
+ WebTextInputInfo textInputInfo;
+ for (size_t i = 0; i < WTF_ARRAY_LENGTH(focusedElements); ++i) {
+ currentFocus = document->getElementById(focusedElements[i].elementId);
+ EXPECT_EQ(currentFocus, document->FocusedElement());
+ textInputInfo = activeInputMethodController->TextInputInfo();
+ EXPECT_EQ(focusedElements[i].textInputFlags, textInputInfo.flags);
+ webViewImpl->MainFrameImpl()->AdvanceFocusInForm(kWebFocusTypeForward);
+ }
+ // Now focus will stay on previous focus itself, because it has no next
+ // element.
+ EXPECT_EQ(currentFocus, document->FocusedElement());
+
+ // Backward Navigation in form1 with PREVIOUS
+ for (size_t i = WTF_ARRAY_LENGTH(focusedElements); i-- > 0;) {
+ currentFocus = document->getElementById(focusedElements[i].elementId);
+ EXPECT_EQ(currentFocus, document->FocusedElement());
+ textInputInfo = activeInputMethodController->TextInputInfo();
+ EXPECT_EQ(focusedElements[i].textInputFlags, textInputInfo.flags);
+ webViewImpl->MainFrameImpl()->AdvanceFocusInForm(kWebFocusTypeBackward);
+ }
+ // Now focus will stay on previous focus itself, because it has no previous
+ // element.
+ EXPECT_EQ(currentFocus, document->FocusedElement());
+
+ // Setting a non editable element as focus in form1, and ensuring editable
+ // navigation is fine in forward and backward.
+ Element* anchor2 = document->getElementById("anchor2");
+ anchor2->focus();
+ textInputInfo = activeInputMethodController->TextInputInfo();
+ // No Next/Previous element for elements outside form.
+ EXPECT_EQ(0, textInputInfo.flags);
+ webViewImpl->MainFrameImpl()->AdvanceFocusInForm(kWebFocusTypeForward);
+ // No editable element after this inside the form, hence focus won't change.
+ EXPECT_EQ(anchor2, document->FocusedElement());
+ webViewImpl->MainFrameImpl()->AdvanceFocusInForm(kWebFocusTypeBackward);
+ // Since anchor is not a form control element, next/previous element will
+ // be null, hence focus will stay same as it is.
+ EXPECT_EQ(anchor2, document->FocusedElement());
+
+ web_view_helper_.Reset();
+}
+
+TEST_P(WebViewTest, MoveFocusToNextFocusableElementInFormWithTabIndexElements) {
+ const std::string testFile =
+ "advance_focus_in_form_with_tabindex_elements.html";
+ RegisterMockedHttpURLLoad(testFile);
+ WebViewImpl* webViewImpl =
+ web_view_helper_.InitializeAndLoad(base_url_ + testFile);
+ webViewImpl->SetInitialFocus(false);
+ Document* document = webViewImpl->MainFrameImpl()->GetFrame()->GetDocument();
+ WebInputMethodController* activeInputMethodController =
+ webViewImpl->MainFrameImpl()
+ ->FrameWidget()
+ ->GetActiveWebInputMethodController();
+ const int defaultTextInputFlags = kWebTextInputFlagAutocapitalizeSentences;
+
+ struct FocusedElement {
+ const char* elementId;
+ int textInputFlags;
+ } focusedElements[] = {
+ {"textarea6",
+ defaultTextInputFlags | kWebTextInputFlagHaveNextFocusableElement},
+ {"input5", defaultTextInputFlags |
+ kWebTextInputFlagHaveNextFocusableElement |
+ kWebTextInputFlagHavePreviousFocusableElement},
+ {"contenteditable4", kWebTextInputFlagHaveNextFocusableElement |
+ kWebTextInputFlagHavePreviousFocusableElement},
+ {"input6",
+ defaultTextInputFlags | kWebTextInputFlagHavePreviousFocusableElement},
+ };
+
+ // Forward Navigation in form with NEXT which has tabindex attribute
+ // which differs visual order.
+ Element* textarea6 = document->getElementById("textarea6");
+ textarea6->focus();
+ Element* currentFocus = nullptr;
+ WebTextInputInfo textInputInfo;
+ for (size_t i = 0; i < WTF_ARRAY_LENGTH(focusedElements); ++i) {
+ currentFocus = document->getElementById(focusedElements[i].elementId);
+ EXPECT_EQ(currentFocus, document->FocusedElement());
+ textInputInfo = activeInputMethodController->TextInputInfo();
+ EXPECT_EQ(focusedElements[i].textInputFlags, textInputInfo.flags);
+ webViewImpl->MainFrameImpl()->AdvanceFocusInForm(kWebFocusTypeForward);
+ }
+ // No next editable element which is focusable with proper tab index, hence
+ // staying on previous focus.
+ EXPECT_EQ(currentFocus, document->FocusedElement());
+
+ // Backward Navigation in form with PREVIOUS which has tabindex attribute
+ // which differs visual order.
+ for (size_t i = WTF_ARRAY_LENGTH(focusedElements); i-- > 0;) {
+ currentFocus = document->getElementById(focusedElements[i].elementId);
+ EXPECT_EQ(currentFocus, document->FocusedElement());
+ textInputInfo = activeInputMethodController->TextInputInfo();
+ EXPECT_EQ(focusedElements[i].textInputFlags, textInputInfo.flags);
+ webViewImpl->MainFrameImpl()->AdvanceFocusInForm(kWebFocusTypeBackward);
+ }
+ // Now focus will stay on previous focus itself, because it has no previous
+ // element.
+ EXPECT_EQ(currentFocus, document->FocusedElement());
+
+ // Setting an element which has invalid tabindex and ensuring it is not
+ // modifying further navigation.
+ Element* contenteditable5 = document->getElementById("contenteditable5");
+ contenteditable5->focus();
+ webViewImpl->MainFrameImpl()->AdvanceFocusInForm(kWebFocusTypeForward);
+ Element* input6 = document->getElementById("input6");
+ EXPECT_EQ(input6, document->FocusedElement());
+ contenteditable5->focus();
+ webViewImpl->MainFrameImpl()->AdvanceFocusInForm(kWebFocusTypeBackward);
+ EXPECT_EQ(textarea6, document->FocusedElement());
+
+ web_view_helper_.Reset();
+}
+
+TEST_P(WebViewTest,
+ MoveFocusToNextFocusableElementInFormWithDisabledAndReadonlyElements) {
+ const std::string testFile =
+ "advance_focus_in_form_with_disabled_and_readonly_elements.html";
+ RegisterMockedHttpURLLoad(testFile);
+ WebViewImpl* webViewImpl =
+ web_view_helper_.InitializeAndLoad(base_url_ + testFile);
+ webViewImpl->SetInitialFocus(false);
+ Document* document = webViewImpl->MainFrameImpl()->GetFrame()->GetDocument();
+ WebInputMethodController* activeInputMethodController =
+ webViewImpl->MainFrameImpl()
+ ->FrameWidget()
+ ->GetActiveWebInputMethodController();
+
+ struct FocusedElement {
+ const char* elementId;
+ int textInputFlags;
+ } focusedElements[] = {
+ {"contenteditable6", kWebTextInputFlagHaveNextFocusableElement},
+ {"contenteditable7", kWebTextInputFlagHavePreviousFocusableElement},
+ };
+ // Forward Navigation in form with NEXT which has has disabled/enabled
+ // elements which will gets skipped during navigation.
+ Element* contenteditable6 = document->getElementById("contenteditable6");
+ contenteditable6->focus();
+ Element* currentFocus = nullptr;
+ WebTextInputInfo textInputInfo;
+ for (size_t i = 0; i < WTF_ARRAY_LENGTH(focusedElements); ++i) {
+ currentFocus = document->getElementById(focusedElements[i].elementId);
+ EXPECT_EQ(currentFocus, document->FocusedElement());
+ textInputInfo = activeInputMethodController->TextInputInfo();
+ EXPECT_EQ(focusedElements[i].textInputFlags, textInputInfo.flags);
+ webViewImpl->MainFrameImpl()->AdvanceFocusInForm(kWebFocusTypeForward);
+ }
+ // No next editable element which is focusable, hence staying on previous
+ // focus.
+ EXPECT_EQ(currentFocus, document->FocusedElement());
+
+ // Backward Navigation in form with PREVIOUS which has has
+ // disabled/enabled elements which will gets skipped during navigation.
+ for (size_t i = WTF_ARRAY_LENGTH(focusedElements); i-- > 0;) {
+ currentFocus = document->getElementById(focusedElements[i].elementId);
+ EXPECT_EQ(currentFocus, document->FocusedElement());
+ textInputInfo = activeInputMethodController->TextInputInfo();
+ EXPECT_EQ(focusedElements[i].textInputFlags, textInputInfo.flags);
+ webViewImpl->MainFrameImpl()->AdvanceFocusInForm(kWebFocusTypeBackward);
+ }
+ // Now focus will stay on previous focus itself, because it has no previous
+ // element.
+ EXPECT_EQ(currentFocus, document->FocusedElement());
+
+ web_view_helper_.Reset();
+}
+
TEST_P(WebViewTest, ExitingDeviceEmulationResetsPageScale) {
RegisterMockedHttpURLLoad("200-by-300.html");
WebViewImpl* web_view_impl =

Powered by Google App Engine
This is Rietveld 408576698