Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1393)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/input/ImeUtils.java

Issue 2839993002: [Android] Adding Smart GO/NEXT feature in Chrome (Closed)
Patch Set: Fixed FocusController and ImeAdapter related review comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/input/ImeUtils.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/input/ImeUtils.java b/content/public/android/java/src/org/chromium/content/browser/input/ImeUtils.java
index 49726776c49baedb8e0e14ee3e365a438b160e87..a5a904f420e0b2cc1d64fd7da20faa454550d5d2 100644
--- a/content/public/android/java/src/org/chromium/content/browser/input/ImeUtils.java
+++ b/content/public/android/java/src/org/chromium/content/browser/input/ImeUtils.java
@@ -46,10 +46,10 @@ public class ImeUtils {
}
int imeAction = 0;
+ boolean enterKeyAction = false;
Changwan Ryu 2017/05/09 14:43:57 remove?
AKVT 2017/05/09 17:22:17 Done.
if (inputMode == WebTextInputMode.DEFAULT) {
if (inputType == TextInputType.TEXT) {
// Normal text field
- imeAction = EditorInfo.IME_ACTION_GO;
if ((inputFlags & WebTextInputFlags.AUTOCORRECT_OFF) == 0) {
outAttrs.inputType |= EditorInfo.TYPE_TEXT_FLAG_AUTO_CORRECT;
}
@@ -59,33 +59,27 @@ public class ImeUtils {
if ((inputFlags & WebTextInputFlags.AUTOCORRECT_OFF) == 0) {
outAttrs.inputType |= EditorInfo.TYPE_TEXT_FLAG_AUTO_CORRECT;
}
- imeAction = EditorInfo.IME_ACTION_NONE;
} else if (inputType == TextInputType.PASSWORD) {
outAttrs.inputType =
InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_WEB_PASSWORD;
- imeAction = EditorInfo.IME_ACTION_GO;
} else if (inputType == TextInputType.SEARCH) {
imeAction = EditorInfo.IME_ACTION_SEARCH;
} else if (inputType == TextInputType.URL) {
outAttrs.inputType = InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_URI;
- imeAction = EditorInfo.IME_ACTION_GO;
} else if (inputType == TextInputType.EMAIL) {
// Email
outAttrs.inputType =
InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_WEB_EMAIL_ADDRESS;
- imeAction = EditorInfo.IME_ACTION_GO;
} else if (inputType == TextInputType.TELEPHONE) {
// Telephone
// Number and telephone do not have both a Tab key and an
// action in default OSK, so set the action to NEXT
outAttrs.inputType = InputType.TYPE_CLASS_PHONE;
- imeAction = EditorInfo.IME_ACTION_NEXT;
} else if (inputType == TextInputType.NUMBER) {
// Number
outAttrs.inputType = InputType.TYPE_CLASS_NUMBER
| InputType.TYPE_NUMBER_VARIATION_NORMAL
| InputType.TYPE_NUMBER_FLAG_DECIMAL;
- imeAction = EditorInfo.IME_ACTION_NEXT;
}
} else {
switch (inputMode) {
@@ -103,31 +97,40 @@ public class ImeUtils {
if ((inputFlags & WebTextInputFlags.AUTOCORRECT_OFF) == 0) {
outAttrs.inputType |= EditorInfo.TYPE_TEXT_FLAG_AUTO_CORRECT;
}
- imeAction = EditorInfo.IME_ACTION_NONE;
break;
case WebTextInputMode.NUMERIC:
outAttrs.inputType =
InputType.TYPE_CLASS_NUMBER | InputType.TYPE_NUMBER_VARIATION_NORMAL;
- imeAction = EditorInfo.IME_ACTION_NEXT;
break;
case WebTextInputMode.TEL:
outAttrs.inputType = InputType.TYPE_CLASS_PHONE;
- imeAction = EditorInfo.IME_ACTION_NEXT;
break;
case WebTextInputMode.EMAIL:
outAttrs.inputType = InputType.TYPE_CLASS_TEXT
| InputType.TYPE_TEXT_VARIATION_WEB_EMAIL_ADDRESS;
- imeAction = EditorInfo.IME_ACTION_GO;
break;
case WebTextInputMode.URL:
outAttrs.inputType =
InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_URI;
- imeAction = EditorInfo.IME_ACTION_NEXT;
break;
}
}
outAttrs.imeOptions |= imeAction;
+
+ // For multiline text or any text input with key event listeners, ENTER key is needed.
+ if ((outAttrs.inputType & EditorInfo.TYPE_TEXT_FLAG_MULTI_LINE) != 0) {
+ // For textarea that sends you to another webpage on enter key press using
+ // JavaScript, we will only show ENTER.
+ outAttrs.imeOptions |= EditorInfo.IME_ACTION_NONE;
+ } else if ((inputFlags & WebTextInputFlags.HAVE_NEXT_FOCUSABLE_ELEMENT) != 0) {
+ outAttrs.imeOptions |= EditorInfo.IME_ACTION_NEXT;
+ } else {
+ // For last element inside form, we should give preference to GO key as PREVIOUS
+ // has less importance in those cases.
+ outAttrs.imeOptions |= EditorInfo.IME_ACTION_GO;
+ }
+
// Handling of autocapitalize. Blink will send the flag taking into account the element's
// type. This is not using AutocapitalizeNone because Android does not autocapitalize by
// default and there is no way to express no capitalization.

Powered by Google App Engine
This is Rietveld 408576698