Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Side by Side Diff: content/common/frame_messages.h

Issue 2839993002: [Android] Adding Smart GO/NEXT feature in Chrome (Closed)
Patch Set: Moved the Focus movement logic from IMC to FocusController and addressed other review comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // IPC messages for interacting with frames. 5 // IPC messages for interacting with frames.
6 // Multiply-included message file, hence no include guard. 6 // Multiply-included message file, hence no include guard.
7 7
8 #include <stddef.h> 8 #include <stddef.h>
9 #include <stdint.h> 9 #include <stdint.h>
10 10
(...skipping 946 matching lines...) Expand 10 before | Expand all | Expand 10 after
957 content::FrameOwnerProperties /* frame_owner_properties */) 957 content::FrameOwnerProperties /* frame_owner_properties */)
958 958
959 // Request to continue running the sequential focus navigation algorithm in 959 // Request to continue running the sequential focus navigation algorithm in
960 // this frame. |source_routing_id| identifies the frame that issued this 960 // this frame. |source_routing_id| identifies the frame that issued this
961 // request. This message is sent when pressing <tab> or <shift-tab> needs to 961 // request. This message is sent when pressing <tab> or <shift-tab> needs to
962 // find the next focusable element in a cross-process frame. 962 // find the next focusable element in a cross-process frame.
963 IPC_MESSAGE_ROUTED2(FrameMsg_AdvanceFocus, 963 IPC_MESSAGE_ROUTED2(FrameMsg_AdvanceFocus,
964 blink::WebFocusType /* type */, 964 blink::WebFocusType /* type */,
965 int32_t /* source_routing_id */) 965 int32_t /* source_routing_id */)
966 966
967 // Tells the renderer to advance the focus to next input node in the form by
nasko 2017/05/03 23:53:25 nit: s/renderer/RenderFrame/
AKVT 2017/05/04 17:08:03 Done.
968 // moving in specified direction if the currently focused node is a Text node
969 // (textfield, text area or content editable nodes).
970 IPC_MESSAGE_ROUTED1(FrameMsg_AdvanceFocusInForm, bool /* forward */)
nasko 2017/05/03 23:53:25 Instead of passing a bool as parameter, why not pa
AKVT 2017/05/04 17:08:03 Done.
971
967 // Sent when the user wants to search for a word on the page (find-in-page). 972 // Sent when the user wants to search for a word on the page (find-in-page).
968 IPC_MESSAGE_ROUTED3(FrameMsg_Find, 973 IPC_MESSAGE_ROUTED3(FrameMsg_Find,
969 int /* request_id */, 974 int /* request_id */,
970 base::string16 /* search_text */, 975 base::string16 /* search_text */,
971 blink::WebFindOptions) 976 blink::WebFindOptions)
972 977
973 // This message notifies the frame that it is no longer the active frame in the 978 // This message notifies the frame that it is no longer the active frame in the
974 // current find session, and so it should clear its active find match (and no 979 // current find session, and so it should clear its active find match (and no
975 // longer highlight it with special coloring). 980 // longer highlight it with special coloring).
976 IPC_MESSAGE_ROUTED0(FrameMsg_ClearActiveFindMatch) 981 IPC_MESSAGE_ROUTED0(FrameMsg_ClearActiveFindMatch)
(...skipping 679 matching lines...) Expand 10 before | Expand all | Expand 10 after
1656 int /* nfr_request_id */, 1661 int /* nfr_request_id */,
1657 float /* distance */) 1662 float /* distance */)
1658 1663
1659 IPC_MESSAGE_ROUTED0(FrameHostMsg_NavigationHandledByEmbedder) 1664 IPC_MESSAGE_ROUTED0(FrameHostMsg_NavigationHandledByEmbedder)
1660 #endif 1665 #endif
1661 1666
1662 // Adding a new message? Stick to the sort order above: first platform 1667 // Adding a new message? Stick to the sort order above: first platform
1663 // independent FrameMsg, then ifdefs for platform specific FrameMsg, then 1668 // independent FrameMsg, then ifdefs for platform specific FrameMsg, then
1664 // platform independent FrameHostMsg, then ifdefs for platform specific 1669 // platform independent FrameHostMsg, then ifdefs for platform specific
1665 // FrameHostMsg. 1670 // FrameHostMsg.
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698