[Android] Adding Smart GO/NEXT feature in Chrome

content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser.input;
 
 import android.content.ClipData;
 import android.content.ClipboardManager;
 import android.content.Context;
 import android.content.res.Configuration;
@@ skipping 398 matching lines @@
         mRule.commitText("hello", 1);
         mRule.waitAndVerifyUpdateSelection(0, 5, 5, -1, -1);
         mRule.restartInput();
         DOMUtils.clickNode(mRule.getContentViewCore(), "input_text");
         mRule.assertWaitForKeyboardStatus(true);
 
         Assert.assertEquals(5, mRule.getConnectionFactory().getOutAttrs().initialSelStart);
         Assert.assertEquals(5, mRule.getConnectionFactory().getOutAttrs().initialSelEnd);
     }
 
+    private int getImeActions() {
+        return mRule.getInputMethodManagerWrapper().getImeOptions() & EditorInfo.IME_MASK_ACTION;
+    }
+
+    @Test
+    @SmallTest
+    @Feature({"TextInput", "Main"})
+    public void testAdvanceFocusNextAndPrevious() throws Exception {
+        // Forward and backward focus in form2
+        mRule.focusElement("textarea");
+        Assert.assertEquals(EditorInfo.IME_ACTION_NONE, getImeActions());
+
+        // Forward direction focus
+        mRule.performEditorAction(EditorInfo.IME_ACTION_NEXT);
+        Assert.assertEquals(EditorInfo.IME_ACTION_NONE, getImeActions());
+        mRule.performEditorAction(EditorInfo.IME_ACTION_NEXT);
+        Assert.assertEquals(EditorInfo.IME_ACTION_NONE, getImeActions());
+        mRule.performEditorAction(EditorInfo.IME_ACTION_NEXT);
+        Assert.assertTrue((EditorInfo.IME_ACTION_NEXT & getImeActions()) != 0);

[Changwan Ryu, 2017/05/11 09:10:52]

This is somewhat concerning. What values do you get from getImeActions()?

[AKVT, 2017/05/11 09:48:49]

I am getting IME_ACTION_NONE

java.lang.AssertionError: expected:<5> but was:<1>

[Changwan Ryu, 2017/05/11 12:04:37]

IME_ACTION_NEXT = 5, IME_ACTION_NONE = 1

You shouldn't mask the final value here.

Assert.assertEquals(EditorInfo.IME_ACTION_NONE, getImeActions());

here and in other places.

[AKVT, 2017/05/11 12:16:44]

But, I was expecting IME_ACTION_NEXT, because it's a <input id="input_number1"
type="number" /> field. What do you suggest ?

+        mRule.performEditorAction(EditorInfo.IME_ACTION_NEXT);
+        Assert.assertTrue((EditorInfo.IME_ACTION_NEXT & getImeActions()) != 0);
+        mRule.performEditorAction(EditorInfo.IME_ACTION_NEXT);
+        Assert.assertEquals(EditorInfo.IME_ACTION_NONE, getImeActions());
+        // Now we have reached the last element of the form, hence focus won't change after issuing
+        // NEXT.

[Changwan Ryu, 2017/05/11 09:10:52]

So, the last element is content editable, right?
Could you verify it by checking inputType against
EditorInfo.TYPE_TEXT_FLAG_MULTI_LINE and add some comment as such? I just want
to make sure 1) that you cover content editable case. 2) that this really is the
last element.

[AKVT, 2017/05/11 09:48:48]

Even my check to 
Assert.assertEquals(EditorInfo.TYPE_TEXT_FLAG_MULTI_LINE |
InputType.TYPE_TEXT_FLAG_CAP_SENTENCES
            | EditorInfo.TYPE_CLASS_TEXT |
EditorInfo.TYPE_TEXT_VARIATION_WEB_EDIT_TEXT, getInputType()); is failing

java.lang.AssertionError: expected:<147617> but was:<164001>

+        mRule.performEditorAction(EditorInfo.IME_ACTION_NEXT);
+        Assert.assertEquals(EditorInfo.IME_ACTION_NONE, getImeActions());
+
+        // Backward direction focus
+        mRule.performEditorAction(EditorInfo.IME_ACTION_PREVIOUS);
+        Assert.assertTrue((EditorInfo.IME_ACTION_NEXT & getImeActions()) != 0);
+        mRule.performEditorAction(EditorInfo.IME_ACTION_PREVIOUS);
+        Assert.assertTrue((EditorInfo.IME_ACTION_NEXT & getImeActions()) != 0);
+        mRule.performEditorAction(EditorInfo.IME_ACTION_PREVIOUS);
+        Assert.assertEquals(EditorInfo.IME_ACTION_NONE, getImeActions());
+        mRule.performEditorAction(EditorInfo.IME_ACTION_PREVIOUS);
+        Assert.assertEquals(EditorInfo.IME_ACTION_NONE, getImeActions());
+        // Now we have reached the first element of the form, hence focus won't change after issuing
+        // PREVIOUS.
+        mRule.performEditorAction(EditorInfo.IME_ACTION_PREVIOUS);
+        Assert.assertEquals(EditorInfo.IME_ACTION_NONE, getImeActions());
+    }
+
     @Test
     @SmallTest
     @DisabledTest(message = "crbug.com/694812")
     @Feature({"TextInput"})
     public void testShowAndHideSoftInput() throws Exception {
         mRule.focusElement("input_radio", false);
 
         // hideSoftKeyboard(), mRule.restartInput()
         mRule.waitForKeyboardStates(0, 1, 1, new Integer[] {});
 
@@ skipping 1060 matching lines @@
         });
         Assert.assertEquals("abc", mRule.runBlockingOnImeThread(new Callable<CharSequence>() {
             @Override
             public CharSequence call() throws Exception {
                 return connection.getTextBeforeCursor(5, 0);
             }
         }));
     }
 
 }