[Android] Adding Smart GO/NEXT feature in Chrome

content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser.input;
 
 import android.content.ClipData;
 import android.content.ClipboardManager;
 import android.content.Context;
 import android.content.res.Configuration;
@@ skipping 400 matching lines @@
         mRule.restartInput();
         DOMUtils.clickNode(mRule.getContentViewCore(), "input_text");
         mRule.assertWaitForKeyboardStatus(true);
 
         Assert.assertEquals(5, mRule.getConnectionFactory().getOutAttrs().initialSelStart);
         Assert.assertEquals(5, mRule.getConnectionFactory().getOutAttrs().initialSelEnd);
     }
 
     @Test
     @SmallTest
+    @Feature({"TextInput", "Main"})
+    public void testAdvanceFocusNextAndPrevious() throws Exception {
+        // Form1 forward and backward focus

[Changwan Ryu, 2017/05/10 16:20:58]

Do we really need to test both forms? If not, could you remove form1 part of the
test?

[AKVT, 2017/05/11 08:47:39]

Ok. Kind of redundant. Thanks

+        mRule.focusElement("input_text");
+        Assert.assertTrue(
+                (mRule.getInputMethodManagerWrapper().getImeOptions() & EditorInfo.IME_ACTION_NEXT)

[Changwan Ryu, 2017/05/10 16:20:59]

Could you add a new function

private int getImeActions() {
    return mRule.getInputMethodManagerWrapper().getImeOptions() &
EditorInfo.IME_MASK_ACTION;
}

And change this line as
Assert.assertEquals(EditorInfo.IME_ACTION_NEXT, getImeActions());

here and in other places.

[AKVT, 2017/05/11 08:47:39]

Assert.assertEquals(EditorInfo.IME_ACTION_NEXT, getImeActions()); is not working
correctly. Instead I had used Assert.assertTrue((EditorInfo.IME_ACTION_NEXT &
getImeActions()) != 0);

+                != 0);
+
+        // Forward direction focus
+        mRule.performEditorAction(EditorInfo.IME_ACTION_NEXT);
+        Assert.assertTrue(
+                (mRule.getInputMethodManagerWrapper().getImeOptions() & EditorInfo.IME_ACTION_NONE)
+                != 0);
+        mRule.performEditorAction(EditorInfo.IME_ACTION_NEXT);
+        // Now we have reached the last element of the form, hence focus won't change after issuing
+        // NEXT.
+        Assert.assertTrue(
+                (mRule.getInputMethodManagerWrapper().getImeOptions() & EditorInfo.IME_ACTION_NONE)
+                != 0);
+
+        // Backward direction focus
+        mRule.performEditorAction(EditorInfo.IME_ACTION_PREVIOUS);
+        Assert.assertTrue(
+                (mRule.getInputMethodManagerWrapper().getImeOptions() & EditorInfo.IME_ACTION_NONE)
+                != 0);
+        mRule.performEditorAction(EditorInfo.IME_ACTION_PREVIOUS);
+        Assert.assertTrue(
+                (mRule.getInputMethodManagerWrapper().getImeOptions() & EditorInfo.IME_ACTION_NEXT)
+                != 0);
+        mRule.performEditorAction(EditorInfo.IME_ACTION_PREVIOUS);
+        // Now we have reached the first element of the form, hence focus won't change after issuing
+        // PREVIOUS.
+        Assert.assertTrue(
+                (mRule.getInputMethodManagerWrapper().getImeOptions() & EditorInfo.IME_ACTION_NEXT)
+                != 0);
+
+        // Form2 forward and backward focus
+        mRule.focusElement("textarea");
+        Assert.assertTrue(
+                (mRule.getInputMethodManagerWrapper().getImeOptions() & EditorInfo.IME_ACTION_NONE)
+                != 0);
+
+        // Forward direction focus
+        mRule.performEditorAction(EditorInfo.IME_ACTION_NEXT);
+        Assert.assertTrue(
+                (mRule.getInputMethodManagerWrapper().getImeOptions() & EditorInfo.IME_ACTION_NONE)
+                != 0);
+        mRule.performEditorAction(EditorInfo.IME_ACTION_NEXT);
+        Assert.assertTrue(
+                (mRule.getInputMethodManagerWrapper().getImeOptions() & EditorInfo.IME_ACTION_NONE)
+                != 0);
+        mRule.performEditorAction(EditorInfo.IME_ACTION_NEXT);
+        Assert.assertTrue(
+                (mRule.getInputMethodManagerWrapper().getImeOptions() & EditorInfo.IME_ACTION_NEXT)
+                != 0);
+        mRule.performEditorAction(EditorInfo.IME_ACTION_NEXT);
+        Assert.assertTrue(
+                (mRule.getInputMethodManagerWrapper().getImeOptions() & EditorInfo.IME_ACTION_NEXT)
+                != 0);
+        mRule.performEditorAction(EditorInfo.IME_ACTION_NEXT);
+        Assert.assertTrue(
+                (mRule.getInputMethodManagerWrapper().getImeOptions() & EditorInfo.IME_ACTION_NONE)
+                != 0);
+        // Now we have reached the last element of the form, hence focus won't change after issuing
+        // NEXT.
+        mRule.performEditorAction(EditorInfo.IME_ACTION_NEXT);
+        Assert.assertTrue(
+                (mRule.getInputMethodManagerWrapper().getImeOptions() & EditorInfo.IME_ACTION_NONE)
+                != 0);
+
+        // Backward direction focus
+        mRule.performEditorAction(EditorInfo.IME_ACTION_PREVIOUS);
+        Assert.assertTrue(
+                (mRule.getInputMethodManagerWrapper().getImeOptions() & EditorInfo.IME_ACTION_NEXT)
+                != 0);
+        mRule.performEditorAction(EditorInfo.IME_ACTION_PREVIOUS);
+        Assert.assertTrue(
+                (mRule.getInputMethodManagerWrapper().getImeOptions() & EditorInfo.IME_ACTION_NEXT)
+                != 0);
+        mRule.performEditorAction(EditorInfo.IME_ACTION_PREVIOUS);
+        Assert.assertTrue(
+                (mRule.getInputMethodManagerWrapper().getImeOptions() & EditorInfo.IME_ACTION_NONE)
+                != 0);
+        mRule.performEditorAction(EditorInfo.IME_ACTION_PREVIOUS);
+        Assert.assertTrue(
+                (mRule.getInputMethodManagerWrapper().getImeOptions() & EditorInfo.IME_ACTION_NONE)
+                != 0);
+        // Now we have reached the first element of the form, hence focus won't change after issuing
+        // PREVIOUS.
+        mRule.performEditorAction(EditorInfo.IME_ACTION_PREVIOUS);
+        Assert.assertTrue(
+                (mRule.getInputMethodManagerWrapper().getImeOptions() & EditorInfo.IME_ACTION_NONE)
+                != 0);
+    }
+
+    @Test
+    @SmallTest
     @DisabledTest(message = "crbug.com/694812")
     @Feature({"TextInput"})
     public void testShowAndHideSoftInput() throws Exception {
         mRule.focusElement("input_radio", false);
 
         // hideSoftKeyboard(), mRule.restartInput()
         mRule.waitForKeyboardStates(0, 1, 1, new Integer[] {});
 
         // When input connection is null, we still need to set flags to prevent InputMethodService
         // from entering fullscreen mode and from opening custom UI.
@@ skipping 1058 matching lines @@
         });
         Assert.assertEquals("abc", mRule.runBlockingOnImeThread(new Callable<CharSequence>() {
             @Override
             public CharSequence call() throws Exception {
                 return connection.getTextBeforeCursor(5, 0);
             }
         }));
     }
 
 }