[Android] Adding Smart GO/NEXT feature in Chrome

content/public/android/javatests/src/org/chromium/content/browser/input/ImeTest.java

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser.input;
 
 import android.content.ClipData;
 import android.content.ClipboardManager;
 import android.content.Context;
 import android.content.res.Configuration;
@@ skipping 21 matching lines @@
 import org.chromium.content.browser.test.util.JavaScriptUtils;
 import org.chromium.ui.base.ime.TextInputType;
 
 import java.util.concurrent.Callable;
 
 /**
  * IME (input method editor) and text input tests.
  */
 @RunWith(ContentJUnit4ClassRunner.class)
 public class ImeTest {
+    private static final int DEFAULT_IME_OPTIONS =
+            EditorInfo.IME_FLAG_NO_FULLSCREEN | EditorInfo.IME_FLAG_NO_EXTRACT_UI;

[Changwan Ryu, 2017/05/09 18:12:16]

Instead of make another dependency on the production logic, how about adding
IME_ACTION_MASKS = EditorInfo.IME_ACTION_NEXT | EditorInfo.IME_ACTION_PREVIOUS |
EditorInfo.IME_ACTION_GO

and using & operator to check the final value against expected value?

[AKVT, 2017/05/10 09:31:38]

Done. That seems to be more easier.

+
     @Rule
     public ImeActivityTestRule mRule = new ImeActivityTestRule();
 
     @Before
     public void setUp() throws Exception {
         mRule.setUp();
     }
 
     @Test
     @MediumTest
@@ skipping 359 matching lines @@
         mRule.restartInput();
         DOMUtils.clickNode(mRule.getContentViewCore(), "input_text");
         mRule.assertWaitForKeyboardStatus(true);
 
         Assert.assertEquals(5, mRule.getConnectionFactory().getOutAttrs().initialSelStart);
         Assert.assertEquals(5, mRule.getConnectionFactory().getOutAttrs().initialSelEnd);
     }
 
     @Test
     @SmallTest
+    @Feature({"TextInput", "Main"})
+    public void testAdvanceFocusNextAndPrevious() throws Exception {
+        DOMUtils.clickNode(mRule.getContentViewCore(), "input_text");
+        mRule.assertWaitForKeyboardStatus(true);
+        Assert.assertEquals(DEFAULT_IME_OPTIONS | EditorInfo.IME_ACTION_NEXT,

[AKVT, 2017/05/09 17:22:18]

I am seeing a failure in this line. As per the logic it supposed to be 
DEFAULT_IME_OPTIONS | EditorInfo.IME_ACTION_NEXT

And visually also it's correctly appearing on IME

But test is failing as it's coming with DEFAULT_IME_OPTIONS |
EditorInfo.IME_ACTION_NONE.

[Changwan Ryu, 2017/05/09 18:12:16]

My initial guess is that assertWaitForKeyboardStatus(true) isn't actually
waiting for anything since keyboard is already showing from setUp().
It takes a round trip to the renderer process for the click event to restart /
show input.

You'd consider calling mRule.focusElement("input_text") which should wait for
states to be correctly updated.

[AKVT, 2017/05/10 09:31:38]

Thanks. I corrected it using mRule.focusElement();

+                mRule.getInputMethodManagerWrapper().getImeOptions());
+
+        // Forward direction focus
+        mRule.performEditorAction(EditorInfo.IME_ACTION_NEXT);
+        Assert.assertEquals(DEFAULT_IME_OPTIONS | EditorInfo.IME_ACTION_NONE,
+                mRule.getInputMethodManagerWrapper().getImeOptions());
+        mRule.performEditorAction(EditorInfo.IME_ACTION_NEXT);
+        // Now we have reached the last element of the form, hence focus won't change after issuing
+        // NEXT.
+        Assert.assertEquals(DEFAULT_IME_OPTIONS | EditorInfo.IME_ACTION_NONE,
+                mRule.getInputMethodManagerWrapper().getImeOptions());
+    }
+
+    @Test
+    @SmallTest
     @DisabledTest(message = "crbug.com/694812")
     @Feature({"TextInput"})
     public void testShowAndHideSoftInput() throws Exception {
         mRule.focusElement("input_radio", false);
 
         // hideSoftKeyboard(), mRule.restartInput()
         mRule.waitForKeyboardStates(0, 1, 1, new Integer[] {});
 
         // When input connection is null, we still need to set flags to prevent InputMethodService
         // from entering fullscreen mode and from opening custom UI.
@@ skipping 1058 matching lines @@
         });
         Assert.assertEquals("abc", mRule.runBlockingOnImeThread(new Callable<CharSequence>() {
             @Override
             public CharSequence call() throws Exception {
                 return connection.getTextBeforeCursor(5, 0);
             }
         }));
     }
 
 }