[Android] Adding Smart GO/NEXT feature in Chrome

content/public/android/java/src/org/chromium/content/browser/input/ImeUtils.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser.input;
 
 import android.text.Editable;
 import android.text.InputType;
 import android.text.Selection;
 import android.util.StringBuilderPrinter;
@@ skipping 28 matching lines @@
             int initialSelStart, int initialSelEnd, EditorInfo outAttrs) {
         outAttrs.imeOptions = EditorInfo.IME_FLAG_NO_FULLSCREEN | EditorInfo.IME_FLAG_NO_EXTRACT_UI;
         outAttrs.inputType =
                 EditorInfo.TYPE_CLASS_TEXT | EditorInfo.TYPE_TEXT_VARIATION_WEB_EDIT_TEXT;
 
         if ((inputFlags & WebTextInputFlags.AUTOCOMPLETE_OFF) != 0) {
             outAttrs.inputType |= EditorInfo.TYPE_TEXT_FLAG_NO_SUGGESTIONS;
         }
 
         int imeAction = 0;
+        boolean enterKeyAction = false;
         if (inputMode == WebTextInputMode.DEFAULT) {
             if (inputType == TextInputType.TEXT) {
                 // Normal text field
-                imeAction = EditorInfo.IME_ACTION_GO;
                 if ((inputFlags & WebTextInputFlags.AUTOCORRECT_OFF) == 0) {
                     outAttrs.inputType |= EditorInfo.TYPE_TEXT_FLAG_AUTO_CORRECT;
                 }
             } else if (inputType == TextInputType.TEXT_AREA
                     || inputType == TextInputType.CONTENT_EDITABLE) {
                 outAttrs.inputType |= EditorInfo.TYPE_TEXT_FLAG_MULTI_LINE;
                 if ((inputFlags & WebTextInputFlags.AUTOCORRECT_OFF) == 0) {
                     outAttrs.inputType |= EditorInfo.TYPE_TEXT_FLAG_AUTO_CORRECT;
                 }
-                imeAction = EditorInfo.IME_ACTION_NONE;
             } else if (inputType == TextInputType.PASSWORD) {
                 outAttrs.inputType =
                         InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_WEB_PASSWORD;
-                imeAction = EditorInfo.IME_ACTION_GO;
             } else if (inputType == TextInputType.SEARCH) {
                 imeAction = EditorInfo.IME_ACTION_SEARCH;
             } else if (inputType == TextInputType.URL) {
                 outAttrs.inputType = InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_URI;
-                imeAction = EditorInfo.IME_ACTION_GO;
             } else if (inputType == TextInputType.EMAIL) {
                 // Email
                 outAttrs.inputType =
                         InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_WEB_EMAIL_ADDRESS;
-                imeAction = EditorInfo.IME_ACTION_GO;
             } else if (inputType == TextInputType.TELEPHONE) {
                 // Telephone
                 // Number and telephone do not have both a Tab key and an
                 // action in default OSK, so set the action to NEXT
                 outAttrs.inputType = InputType.TYPE_CLASS_PHONE;
-                imeAction = EditorInfo.IME_ACTION_NEXT;
             } else if (inputType == TextInputType.NUMBER) {
                 // Number
                 outAttrs.inputType = InputType.TYPE_CLASS_NUMBER
                         | InputType.TYPE_NUMBER_VARIATION_NORMAL
                         | InputType.TYPE_NUMBER_FLAG_DECIMAL;
-                imeAction = EditorInfo.IME_ACTION_NEXT;
             }
         } else {
             switch (inputMode) {
                 default:
                 case WebTextInputMode.DEFAULT:
                 case WebTextInputMode.VERBATIM:
                 case WebTextInputMode.LATIN:
                 case WebTextInputMode.LATIN_NAME:
                 case WebTextInputMode.LATIN_PROSE:
                 case WebTextInputMode.FULL_WIDTH_LATIN:
@@ skipping 22 matching lines @@
                     break;
                 case WebTextInputMode.URL:
                     outAttrs.inputType =
                             InputType.TYPE_CLASS_TEXT | InputType.TYPE_TEXT_VARIATION_URI;
                     imeAction = EditorInfo.IME_ACTION_NEXT;
                     break;
             }
         }
 
         outAttrs.imeOptions |= imeAction;
+
+        // For multiline text or any text input with key event listeners, ENTER key is needed.
+        if ((outAttrs.inputType & EditorInfo.TYPE_TEXT_FLAG_MULTI_LINE) != 0) {
+            // For textarea that sends you to another webpage on enter key press using
+            // JavaScript, we will only show ENTER.
+            outAttrs.imeOptions |= EditorInfo.IME_ACTION_NONE;
+            enterKeyAction = true;
+        }
+
+        // If ENTER key is already applied, then don't apply NEXT as it can result display issues in
+        // IME

[Changwan Ryu, 2017/05/04 20:38:15]

This comment is not needed at all.

[AKVT, 2017/05/09 11:05:52]

Done.

+        if (!enterKeyAction) {
+            if ((inputFlags & WebTextInputFlags.HAVE_NEXT_FOCUSABLE_ELEMENT) != 0) {
+                outAttrs.imeOptions |= EditorInfo.IME_ACTION_NEXT;
+            } else if ((inputFlags & WebTextInputFlags.HAVE_PREVIOUS_FOCUSABLE_ELEMENT) != 0) {
+                // If ENTER/NEXT key is already applied, then don't apply PREVIOUS as it can result

[Changwan Ryu, 2017/05/04 20:38:15]

No need to mention ENTER case here. Did you mean GO? BTW, GO case handling is
missing.

[AKVT, 2017/05/09 11:05:52]

Yes, I missed GO in subsequent review cycle.
Also PREVIOUS and GO I am not able to apply as it's always taking PREVIOUS as
default action. So last element inside form is difficult to use as submitting
option.

Same case with NEXT and PREVIOUS together, it takes PREVIOUS as primary action,
so ending up switching between only 2 elements inside form. Others are
unreachable without manual touch.

I have tested using Samsung Keyboard 1.5.02 on Galaxy S7 Edge SM-935FD device
with Android 7.0 G935FXXU1DPLT binary.

+                // display issues in IME
+                outAttrs.imeOptions |= EditorInfo.IME_ACTION_PREVIOUS;
+            }
+        }
+
         // Handling of autocapitalize. Blink will send the flag taking into account the element's
         // type. This is not using AutocapitalizeNone because Android does not autocapitalize by
         // default and there is no way to express no capitalization.
         // Autocapitalize is meant as a hint to the virtual keyboard.
         if ((inputFlags & WebTextInputFlags.AUTOCAPITALIZE_CHARACTERS) != 0) {
             outAttrs.inputType |= InputType.TYPE_TEXT_FLAG_CAP_CHARACTERS;
         } else if ((inputFlags & WebTextInputFlags.AUTOCAPITALIZE_WORDS) != 0) {
             outAttrs.inputType |= InputType.TYPE_TEXT_FLAG_CAP_WORDS;
         } else if ((inputFlags & WebTextInputFlags.AUTOCAPITALIZE_SENTENCES) != 0) {
             outAttrs.inputType |= InputType.TYPE_TEXT_FLAG_CAP_SENTENCES;
@@ skipping 56 matching lines @@
         if (!condition) throw new AssertionError(msg);
     }
 
     /**
      * Check that the current thread is UI thread, and raise an error if it is not.
      */
     static void checkOnUiThread() {
         checkCondition("Should be on UI thread.", ThreadUtils.runningOnUiThread());
     }
 }