third_party/WebKit/Source/modules/sensor/SensorProxy.cpp - Issue 2839963004: [Sensors] Error handler in Senor class should stop the platform sensor

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/sensor/SensorProxy.cpp

Issue 2839963004: [Sensors] Error handler in Senor class should stop the platform sensor (Closed)

Patch Set: Added layout test Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/modules/sensor/SensorProxy.cpp

diff --git a/third_party/WebKit/Source/modules/sensor/SensorProxy.cpp b/third_party/WebKit/Source/modules/sensor/SensorProxy.cpp

index b90664646d597c238f39767dc9fc58147b8ff1ee..d7f8d9339d343c52bf2cd593a957056829f4fbf7 100644

--- a/third_party/WebKit/Source/modules/sensor/SensorProxy.cpp

+++ b/third_party/WebKit/Source/modules/sensor/SensorProxy.cpp

@@ -178,7 +178,8 @@ void SensorProxy::HandleSensorError() {

default_config_.reset();

client_binding_.Close();

- for (Observer* observer : observers_) {

+ auto copy = observers_;

+ for (Observer* observer : copy) {

observer->OnSensorError(kNotReadableError, "Could not connect to a sensor",

String());

}