 Chromium Code Reviews
 Chromium Code Reviews Issue 2839963004:
  [Sensors] Error handler in Senor class should stop the platform sensor  (Closed)
    
  
    Issue 2839963004:
  [Sensors] Error handler in Senor class should stop the platform sensor  (Closed) 
  | Index: third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js | 
| diff --git a/third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js b/third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js | 
| index 52783b278800745431f7a657e08da6202422b9da..25ccf1ddbaab53ff1aab6f1fdbbfe52ea06dd5cf 100644 | 
| --- a/third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js | 
| +++ b/third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js | 
| @@ -68,6 +68,33 @@ function runGenericSensorTests(sensorType, updateReading, verifyReading) { | 
| }, 'Test that frequency is capped to 60.0 Hz.'); | 
| sensor_test(sensor => { | 
| + let sensorObject = new sensorType(); | 
| + sensorObject.start(); | 
| + let testPromise = sensor.mockSensorProvider.getCreatedSensor() | 
| + .then(mockSensor => { return mockSensor.addConfigurationCalled(); }) | 
| 
Reilly Grant (use Gerrit)
2017/04/26 14:58:45
.then(mockSensor => mockSensor.addConfigurationCal
 
Mikhail
2017/04/27 07:50:34
Done.
 | 
| + .then(mockSensor => { | 
| + return new Promise((resolve, reject) => { | 
| + sensorObject.onactivate = () => { | 
| + // Now sensor proxy is initialized. | 
| + let anotherSensor = new sensorType({frequency: 21}); | 
| + anotherSensor.start(); | 
| + anotherSensor.stop(); | 
| + resolve(mockSensor); | 
| + } | 
| + }); | 
| + }) | 
| + .then(mockSensor => { return mockSensor.removeConfigurationCalled(); }) | 
| + .then(mockSensor => { | 
| + return new Promise((resolve, reject) => { | 
| + sensorObject.stop(); | 
| + resolve(mockSensor); | 
| + }); | 
| 
Reilly Grant (use Gerrit)
2017/04/26 14:58:45
.then(mockSensor => {
  sensorObject.stop();
  ret
 
Mikhail
2017/04/27 07:50:34
Done.
 | 
| + }) | 
| + .then(mockSensor => { return mockSensor.removeConfigurationCalled(); }); | 
| + return testPromise; | 
| 
Reilly Grant (use Gerrit)
2017/04/26 14:58:45
nit: return sensor.mockSensorProvider.... above
 
Mikhail
2017/04/27 07:50:33
Done.
 | 
| + }, 'Test that configuration is removed for a stopped sensor.'); | 
| + | 
| + sensor_test(sensor => { | 
| let maxSupportedFrequency = 15; | 
| sensor.mockSensorProvider.setMaximumSupportedFrequency(maxSupportedFrequency); | 
| let sensorObject = new sensorType({frequency: 50}); |