[Sensors] Error handler in Senor class should stop the platform sensor

third_party/WebKit/LayoutTests/sensor/resources/generic-sensor-tests.js

 'use strict';
 
 // Run a set of tests for a given |sensorType|. |updateReading| is
 // a called by the test to provide the mock values for sensor. |verifyReading|
 // is called so that the value read in JavaScript are the values expected (the ones
 // sent by |updateReading|).
 function runGenericSensorTests(sensorType, updateReading, verifyReading) {
   sensor_test(sensor => {
     sensor.mockSensorProvider.setGetSensorShouldFail(true);
     let sensorObject = new sensorType;
@@ skipping 50 matching lines @@
               }, reject);
               sensorObject.onactivate = wrapper.callback;
               sensorObject.onerror = reject;
             });
           })
           .then(mockSensor => { return mockSensor.removeConfigurationCalled(); });
       return testPromise;
   }, 'Test that frequency is capped to 60.0 Hz.');
 
   sensor_test(sensor => {
+      let sensorObject = new sensorType();
+      sensorObject.start();
+      let testPromise = sensor.mockSensorProvider.getCreatedSensor()
+          .then(mockSensor => { return mockSensor.addConfigurationCalled(); })

[Reilly Grant (use Gerrit), 2017/04/26 14:58:45]

.then(mockSensor => mockSensor.addConfigurationCalled())

(same below)

[Mikhail, 2017/04/27 07:50:34]

Done.

+          .then(mockSensor => {
+            return new Promise((resolve, reject) => {
+              sensorObject.onactivate = () => {
+                // Now sensor proxy is initialized.
+                let anotherSensor = new sensorType({frequency: 21});
+                anotherSensor.start();
+                anotherSensor.stop();
+                resolve(mockSensor);
+              }
+            });
+          })
+          .then(mockSensor => { return mockSensor.removeConfigurationCalled(); })
+          .then(mockSensor => {
+            return new Promise((resolve, reject) => {
+              sensorObject.stop();
+              resolve(mockSensor);
+            });

[Reilly Grant (use Gerrit), 2017/04/26 14:58:45]

.then(mockSensor => {
  sensorObject.stop();
  return mockSensor;
})

[Mikhail, 2017/04/27 07:50:34]

Done.

+          })
+          .then(mockSensor => { return mockSensor.removeConfigurationCalled(); });
+      return testPromise;

[Reilly Grant (use Gerrit), 2017/04/26 14:58:45]

nit: return sensor.mockSensorProvider.... above

[Mikhail, 2017/04/27 07:50:33]

Done.

+  }, 'Test that configuration is removed for a stopped sensor.');
+
+  sensor_test(sensor => {
     let maxSupportedFrequency = 15;
     sensor.mockSensorProvider.setMaximumSupportedFrequency(maxSupportedFrequency);
     let sensorObject = new sensorType({frequency: 50});
     sensorObject.start();
     let testPromise = sensor.mockSensorProvider.getCreatedSensor()
         .then(mockSensor => { return mockSensor.addConfigurationCalled(); })
         .then(mockSensor => {
           return new Promise((resolve, reject) => {
             let wrapper = new CallbackWrapper(() => {
               let configuration = mockSensor.active_sensor_configurations_[0];
@@ skipping 264 matching lines @@
 
   sensor_test(sensor => {
     return checkFrequencyHintWorks(sensor);
   }, 'Test that frequency hint works (onchange reporting).');
 
   sensor_test(sensor => {
     sensor.mockSensorProvider.setContinuousReportingMode();
     return checkFrequencyHintWorks(sensor);
   }, 'Test that frequency hint works (continuous reporting).');
 }