chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm - Issue 2839893003: cocoa: allow omnibox decorations to become key

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm

Issue 2839893003: cocoa: allow omnibox decorations to become key (Closed)

Patch Set: fix nits Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.h ('k') | chrome/browser/ui/cocoa/location_bar/location_bar_decoration.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm

diff --git a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm

index fade6898f5157e459a726971b385b76c09c53089..e09ee0d517737e9da1027f40134298b071d15dad 100644

--- a/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm

+++ b/chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm

@@ -736,6 +736,13 @@ - (void)handleFocusEvent:(NSEvent*)event

}

+- (int)leadingDecorationIndex:(LocationBarDecoration*)decoration {

+ for (size_t i = 0; i < leadingDecorations_.size(); ++i)

+ if (leadingDecorations_[i] == decoration)

+ return leadingDecorations_.size() - (i + 1);

+ return -1;

@end

@implementation AutocompleteTextFieldCell (TestingAPI)