cocoa: allow omnibox decorations to become key

chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.h"
 
 #include <stddef.h>
 
 #include "base/logging.h"
 #include "base/mac/foundation_util.h"
@@ skipping 718 matching lines @@
 }
 
 - (void)handleFocusEvent:(NSEvent*)event
                   ofView:(AutocompleteTextField*)controlView {
   if ([controlView observer]) {
     const bool controlDown = ([event modifierFlags] & NSControlKeyMask) != 0;
     [controlView observer]->OnSetFocus(controlDown);
   }
 }
 
+- (int)leadingDecorationIndex:(LocationBarDecoration*)decoration {
+  for (size_t i = 0; i < leadingDecorations_.size(); ++i)

[Mark Mentovai, 2017/04/25 20:44:31]

I like to use std::find and std::distance for this kind of thing, but you’re
free to ignore the suggestion. Some people like the explicit loop better, and
that’s OK too.

[Elly Fong-Jones, 2017/04/26 16:50:01]

I prefer the explicit loop, but I'm not quite sure why.

+    if (leadingDecorations_[i] == decoration)
+      return leadingDecorations_.size() - (i + 1);
+  return -1;
+}
+
 @end
 
 @implementation AutocompleteTextFieldCell (TestingAPI)
 
 - (const std::vector<LocationBarDecoration*>&)mouseTrackingDecorations {
   return mouseTrackingDecorations_;
 }
 
 @end