Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3691)

Unified Diff: base/trace_event/trace_event_memory_overhead.cc

Issue 2839753005: Remove base::Value::GetAsBinary (Closed)
Patch Set: ASSERT_TRUE Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/values.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/trace_event_memory_overhead.cc
diff --git a/base/trace_event/trace_event_memory_overhead.cc b/base/trace_event/trace_event_memory_overhead.cc
index 9491f65359ffa6fd35b440a05f04f9f2f8af423c..d23383f701c095b14edad2f59a419b60daaa485a 100644
--- a/base/trace_event/trace_event_memory_overhead.cc
+++ b/base/trace_event/trace_event_memory_overhead.cc
@@ -84,9 +84,7 @@ void TraceEventMemoryOverhead::AddValue(const Value& value) {
} break;
case Value::Type::BINARY: {
- const Value* binary_value = nullptr;
- value.GetAsBinary(&binary_value);
- Add("BinaryValue", sizeof(Value) + binary_value->GetBlob().size());
+ Add("BinaryValue", sizeof(Value) + value.GetBlob().size());
} break;
case Value::Type::DICTIONARY: {
« no previous file with comments | « no previous file | base/values.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698