Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 2839733003: Cache path -> URI mapping in SourceMapPrintingContext. (Closed)

Created:
3 years, 8 months ago by scheglov
Modified:
3 years, 8 months ago
Reviewers:
vsm, Jennifer Messerly
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Cache path -> URI mapping in SourceMapPrintingContext. This improves DDC compiling DDC from 30 to 25 seconds. R=jmesserly@google.com, vsm@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/8e76c78ccec41e991b74542c1b279d8709cf1526

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M pkg/dev_compiler/lib/src/compiler/source_map_printer.dart View 2 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 8 months ago (2017-04-25 02:24:49 UTC) #1
vsm
lgtm!
3 years, 8 months ago (2017-04-25 02:28:04 UTC) #2
scheglov
3 years, 8 months ago (2017-04-25 02:32:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
8e76c78ccec41e991b74542c1b279d8709cf1526 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698