Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Unified Diff: components/autofill/core/browser/autofill_metrics.h

Issue 2839683002: Logs different SaveCardPrompt histogram names depending on if user (Closed)
Patch Set: Uses no-suffix, 'PreviouslyAccepted' and 'PreviouslyDenied' for the save card prompt histograms. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_metrics.h
diff --git a/components/autofill/core/browser/autofill_metrics.h b/components/autofill/core/browser/autofill_metrics.h
index 58ab8d26aa06d64471b9fe76613a5405d877f61c..ac50c90e59d8e6c4efb4dc79b92b03dc1c7722c0 100644
--- a/components/autofill/core/browser/autofill_metrics.h
+++ b/components/autofill/core/browser/autofill_metrics.h
@@ -16,6 +16,7 @@
#include "components/autofill/core/browser/autofill_profile.h"
#include "components/autofill/core/browser/credit_card.h"
#include "components/autofill/core/browser/field_types.h"
+#include "components/autofill/core/common/autofill_pref_names.h"
#include "components/autofill/core/common/form_field_data.h"
namespace ukm {
@@ -645,12 +646,16 @@ class AutofillMetrics {
};
static void LogCardUploadDecisionMetric(CardUploadDecisionMetric metric);
- static void LogCreditCardInfoBarMetric(InfoBarMetric metric,
- bool is_uploading);
+ static void LogCreditCardInfoBarMetric(
+ InfoBarMetric metric,
+ bool is_uploading,
+ int previous_save_credit_card_prompt_user_decision);
static void LogCreditCardFillingInfoBarMetric(InfoBarMetric metric);
- static void LogSaveCardPromptMetric(SaveCardPromptMetric metric,
- bool is_uploading,
- bool is_reshow);
+ static void LogSaveCardPromptMetric(
+ SaveCardPromptMetric metric,
+ bool is_uploading,
+ bool is_reshow,
+ int previous_save_credit_card_prompt_user_decision);
static void LogScanCreditCardPromptMetric(ScanCreditCardPromptMetric metric);
// Should be called when credit card scan is finished. |duration| should be

Powered by Google App Engine
This is Rietveld 408576698