Logs different SaveCardPrompt histogram names depending on if user

components/autofill/core/browser/autofill_metrics.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/autofill/core/browser/autofill_metrics.h"
 
 #include <algorithm>
 #include <utility>
 #include <vector>
 
@@ skipping 62 matching lines @@
   GROUP_CREDIT_CARD_DATE,
   GROUP_CREDIT_CARD_TYPE,
   GROUP_PASSWORD,
   GROUP_ADDRESS_LINE_3,
   GROUP_USERNAME,
   GROUP_STREET_ADDRESS,
   GROUP_CREDIT_CARD_VERIFICATION,
   NUM_FIELD_TYPE_GROUPS_FOR_METRICS
 };
 
+std::string PreviousSaveCreditCardPromptUserDecisionToString(
+    int previous_save_credit_card_prompt_user_decision) {
+  DCHECK_LT(previous_save_credit_card_prompt_user_decision,
+            prefs::NUM_PREVIOUS_SAVE_CREDIT_CARD_PROMPT_USER_DECISIONS);
+  std::string previous_response;
+  if (previous_save_credit_card_prompt_user_decision ==
+      prefs::PREVIOUS_SAVE_CREDIT_CARD_PROMPT_USER_DECISION_ACCEPTED)
+    previous_response = ".PreviouslyAccepted";
+  else if (previous_save_credit_card_prompt_user_decision ==
+           prefs::PREVIOUS_SAVE_CREDIT_CARD_PROMPT_USER_DECISION_DENIED)
+    previous_response = ".PreviouslyDenied";
+  return previous_response;

[Mark P, 2017/04/27 22:52:58]

optional nit while I'm here:
DCHECK_EQ(PREVIOUS_SAVE_CREDIT_CARD_PROMPT_USER_DECISION_NONE,
previous_save_credit_card_prompt_user_decision);

[csashi, 2017/04/27 23:37:51]

Done.

+}
+
 }  // namespace
 
 // First, translates |field_type| to the corresponding logical |group| from
 // |FieldTypeGroupForMetrics|.  Then, interpolates this with the given |metric|,
 // which should be in the range [0, |num_possible_metrics|).
 // Returns the interpolated index.
 //
 // The interpolation maps the pair (|group|, |metric|) to a single index, so
 // that all the indicies for a given group are adjacent.  In particular, with
 // the groups {AMBIGUOUS, NAME, ...} combining with the metrics {UNKNOWN, MATCH,
@@ skipping 198 matching lines @@
 
 // static
 void AutofillMetrics::LogCardUploadDecisionMetric(
     CardUploadDecisionMetric metric) {
   DCHECK_LT(metric, NUM_CARD_UPLOAD_DECISION_METRICS);
   UMA_HISTOGRAM_ENUMERATION("Autofill.CardUploadDecisionExpanded", metric,
                             NUM_CARD_UPLOAD_DECISION_METRICS);
 }
 
 // static
-void AutofillMetrics::LogCreditCardInfoBarMetric(InfoBarMetric metric,
-                                                 bool is_uploading) {
+void AutofillMetrics::LogCreditCardInfoBarMetric(
+    InfoBarMetric metric,
+    bool is_uploading,
+    int previous_save_credit_card_prompt_user_decision) {
   DCHECK_LT(metric, NUM_INFO_BAR_METRICS);
-  if (is_uploading) {
-    UMA_HISTOGRAM_ENUMERATION("Autofill.CreditCardInfoBar.Server", metric,
-                              NUM_INFO_BAR_METRICS);
-  } else {
-    UMA_HISTOGRAM_ENUMERATION("Autofill.CreditCardInfoBar.Local", metric,
-                              NUM_INFO_BAR_METRICS);
-  }
+
+  std::string destination = is_uploading ? ".Server" : ".Local";
+  LogUMAHistogramEnumeration(
+      "Autofill.CreditCardInfoBar" + destination +
+          PreviousSaveCreditCardPromptUserDecisionToString(

[Mark P, 2017/04/27 22:52:58]

This structure makes is to there is no longer a single summary metric regardless
of a previous decision.  You only have three sliced metrics (previously
accepted, previously denied, nothing previous).  There is no way to view the
aggregate without manually adding up those separate histograms.  Please consider
whether viewing the aggregate would be useful.

(I imagine so, but I won't force you to do if you don't think so.)

Ditto with all changes below.

[csashi, 2017/04/27 23:37:51]

It is useful to view the aggregate but I would rather burden the downstream
analysis tools rather than Chrome client. Also, it is consistent with other
stats I have seen. For example, FORM_EVENT_LOCAL_SUGGESTION_FILLED, 
FORM_EVENT_SERVER_SUGGESTION_FILLED and
FORM_EVENT_MASKED_SERVER_CARD_SUGGESTION_FILLED all refer to different types of
suggestion fills and we aggregate it on the analysis side to compute suggestion
usage rate.

+              previous_save_credit_card_prompt_user_decision),
+      metric, NUM_INFO_BAR_METRICS);
 }
 
 // static
 void AutofillMetrics::LogCreditCardFillingInfoBarMetric(InfoBarMetric metric) {
   DCHECK_LT(metric, NUM_INFO_BAR_METRICS);
   UMA_HISTOGRAM_ENUMERATION("Autofill.CreditCardFillingInfoBar", metric,
                             NUM_INFO_BAR_METRICS);
 }
 
 // static
-void AutofillMetrics::LogSaveCardPromptMetric(SaveCardPromptMetric metric,
-                                              bool is_uploading,
-                                              bool is_reshow) {
+void AutofillMetrics::LogSaveCardPromptMetric(
+    SaveCardPromptMetric metric,
+    bool is_uploading,
+    bool is_reshow,
+    int previous_save_credit_card_prompt_user_decision) {
   DCHECK_LT(metric, NUM_SAVE_CARD_PROMPT_METRICS);
   std::string destination = is_uploading ? ".Upload" : ".Local";
   std::string show = is_reshow ? ".Reshows" : ".FirstShow";
   LogUMAHistogramEnumeration(
-      "Autofill.SaveCreditCardPrompt" + destination + show, metric,
-      NUM_SAVE_CARD_PROMPT_METRICS);
+      "Autofill.SaveCreditCardPrompt" + destination + show +
+          PreviousSaveCreditCardPromptUserDecisionToString(
+              previous_save_credit_card_prompt_user_decision),
+      metric, NUM_SAVE_CARD_PROMPT_METRICS);
 }
 
 // static
 void AutofillMetrics::LogScanCreditCardPromptMetric(
     ScanCreditCardPromptMetric metric) {
   DCHECK_LT(metric, NUM_SCAN_CREDIT_CARD_PROMPT_METRICS);
   UMA_HISTOGRAM_ENUMERATION("Autofill.ScanCreditCardPrompt", metric,
                             NUM_SCAN_CREDIT_CARD_PROMPT_METRICS);
 }
 
@@ skipping 788 matching lines @@
   DCHECK(!form_loaded_timestamp_.is_null());
   return (base::TimeTicks::Now() - form_loaded_timestamp_).InMilliseconds();
 }
 
 void AutofillMetrics::FormInteractionsUkmLogger::GetNewSourceID() {
   source_id_ = ukm_service_->GetNewSourceID();
   ukm_service_->UpdateSourceURL(source_id_, url_);
 }
 
 }  // namespace autofill