Logs different SaveCardPrompt histogram names depending on if user

chrome/browser/ui/autofill/save_card_bubble_controller_impl_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/save_card_bubble_controller_impl.h"
 
 #include <stddef.h>
 #include <utility>
 
 #include "base/json/json_reader.h"
 #include "base/macros.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/histogram_tester.h"
 #include "base/values.h"
 #include "chrome/browser/ui/autofill/save_card_bubble_view.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/test/base/browser_with_test_window_test.h"
 #include "chrome/test/base/chrome_render_view_host_test_harness.h"
 #include "components/autofill/core/browser/autofill_metrics.h"
 #include "components/autofill/core/browser/credit_card.h"
+#include "components/autofill/core/common/autofill_pref_names.h"
+#include "components/user_prefs/user_prefs.h"
 #include "content/public/browser/navigation_handle.h"
 #include "testing/gmock/include/gmock/gmock.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 using base::Bucket;
 using testing::ElementsAre;
 
 namespace autofill {
 
 class TestSaveCardBubbleControllerImpl : public SaveCardBubbleControllerImpl {
@@ skipping 23 matching lines @@
   base::TimeDelta elapsed_;
 };
 
 class SaveCardBubbleControllerImplTest : public BrowserWithTestWindowTest {
  public:
   SaveCardBubbleControllerImplTest() {}
 
   void SetUp() override {
     BrowserWithTestWindowTest::SetUp();
     AddTab(browser(), GURL("about:blank"));
-    TestSaveCardBubbleControllerImpl::CreateForTesting(
-        browser()->tab_strip_model()->GetActiveWebContents());
+    content::WebContents* web_contents =
+        browser()->tab_strip_model()->GetActiveWebContents();
+    TestSaveCardBubbleControllerImpl::CreateForTesting(web_contents);
+    user_prefs::UserPrefs::Get(web_contents->GetBrowserContext())
+        ->SetBoolean(prefs::kAutofillAcceptSaveCreditCardPromptState, true);
   }
 
   BrowserWindow* CreateBrowserWindow() override {
     return new SaveCardBubbleTestBrowserWindow();
   }
 
   void SetLegalMessage(const std::string& message_json,
                        bool should_cvc_be_requested = false) {
     std::unique_ptr<base::Value> value(base::JSONReader::Read(message_json));
     ASSERT_TRUE(value);
@@ skipping 78 matching lines @@
   ShowUploadBubble(true /* should_cvc_be_requested */);
   EXPECT_TRUE(controller()->ShouldRequestCvcFromUser());
 }
 
 TEST_F(SaveCardBubbleControllerImplTest, Metrics_Local_FirstShow_ShowBubble) {
   base::HistogramTester histogram_tester;
   ShowLocalBubble();
 
   EXPECT_THAT(
       histogram_tester.GetAllSamples(
-          "Autofill.SaveCreditCardPrompt.Local.FirstShow"),
+          "Autofill.SaveCreditCardPrompt.Local.FirstShow.PreviouslyAccepted"),
       ElementsAre(Bucket(AutofillMetrics::SAVE_CARD_PROMPT_SHOW_REQUESTED, 1),
                   Bucket(AutofillMetrics::SAVE_CARD_PROMPT_SHOWN, 1)));
 }
 
 TEST_F(SaveCardBubbleControllerImplTest, Metrics_Local_Reshows_ShowBubble) {
   ShowLocalBubble();
 
   base::HistogramTester histogram_tester;
   CloseAndReshowBubble();
 
   EXPECT_THAT(
       histogram_tester.GetAllSamples(
-          "Autofill.SaveCreditCardPrompt.Local.Reshows"),
+          "Autofill.SaveCreditCardPrompt.Local.Reshows.PreviouslyAccepted"),
       ElementsAre(Bucket(AutofillMetrics::SAVE_CARD_PROMPT_SHOW_REQUESTED, 1),
                   Bucket(AutofillMetrics::SAVE_CARD_PROMPT_SHOWN, 1)));
 }
 
 TEST_F(SaveCardBubbleControllerImplTest,
        Metrics_Upload_FirstShow_ShowBubble_NotRequestCvc) {
   base::HistogramTester histogram_tester;
   ShowUploadBubble();
 
   EXPECT_THAT(
       histogram_tester.GetAllSamples(
-          "Autofill.SaveCreditCardPrompt.Upload.FirstShow"),
+          "Autofill.SaveCreditCardPrompt.Upload.FirstShow.PreviouslyAccepted"),
       ElementsAre(Bucket(AutofillMetrics::SAVE_CARD_PROMPT_SHOW_REQUESTED, 1),
                   Bucket(AutofillMetrics::SAVE_CARD_PROMPT_SHOWN, 1)));
 }
 
 TEST_F(SaveCardBubbleControllerImplTest,
        Metrics_Upload_FirstShow_ShowBubble_RequestCvc) {
   base::HistogramTester histogram_tester;
   ShowUploadBubble(true /* should_cvc_be_requested */);
 
   EXPECT_THAT(
       histogram_tester.GetAllSamples(
-          "Autofill.SaveCreditCardPrompt.Upload.FirstShow"),
+          "Autofill.SaveCreditCardPrompt.Upload.FirstShow.PreviouslyAccepted"),
       ElementsAre(Bucket(AutofillMetrics::SAVE_CARD_PROMPT_SHOW_REQUESTED, 1),
                   Bucket(AutofillMetrics::SAVE_CARD_PROMPT_SHOWN, 1)));
 }
 
 TEST_F(SaveCardBubbleControllerImplTest, Metrics_Upload_Reshows_ShowBubble) {
   ShowUploadBubble();
 
   base::HistogramTester histogram_tester;
   CloseAndReshowBubble();
 
   EXPECT_THAT(
       histogram_tester.GetAllSamples(
-          "Autofill.SaveCreditCardPrompt.Upload.Reshows"),
+          "Autofill.SaveCreditCardPrompt.Upload.Reshows.PreviouslyAccepted"),
       ElementsAre(Bucket(AutofillMetrics::SAVE_CARD_PROMPT_SHOW_REQUESTED, 1),
                   Bucket(AutofillMetrics::SAVE_CARD_PROMPT_SHOWN, 1)));
 }
 
 TEST_F(SaveCardBubbleControllerImplTest, Metrics_Local_FirstShow_SaveButton) {
   ShowLocalBubble();
 
   base::HistogramTester histogram_tester;
   controller()->OnSaveButton();
   controller()->OnBubbleClosed();
 
   histogram_tester.ExpectUniqueSample(
-      "Autofill.SaveCreditCardPrompt.Local.FirstShow",
+      "Autofill.SaveCreditCardPrompt.Local.FirstShow.PreviouslyAccepted",
       AutofillMetrics::SAVE_CARD_PROMPT_END_ACCEPTED, 1);
 }
 
 TEST_F(SaveCardBubbleControllerImplTest, Metrics_Local_Reshows_SaveButton) {
   ShowLocalBubble();
   CloseAndReshowBubble();
 
   base::HistogramTester histogram_tester;
   controller()->OnSaveButton();
   controller()->OnBubbleClosed();
 
   histogram_tester.ExpectUniqueSample(
-      "Autofill.SaveCreditCardPrompt.Local.Reshows",
+      "Autofill.SaveCreditCardPrompt.Local.Reshows.PreviouslyAccepted",
       AutofillMetrics::SAVE_CARD_PROMPT_END_ACCEPTED, 1);
 }
 
 TEST_F(SaveCardBubbleControllerImplTest, Metrics_Local_FirstShow_CancelButton) {
   ShowLocalBubble();
 
   base::HistogramTester histogram_tester;
   controller()->OnCancelButton();
   controller()->OnBubbleClosed();
 
   histogram_tester.ExpectUniqueSample(
-      "Autofill.SaveCreditCardPrompt.Local.FirstShow",
+      "Autofill.SaveCreditCardPrompt.Local.FirstShow.PreviouslyAccepted",
       AutofillMetrics::SAVE_CARD_PROMPT_END_DENIED, 1);
 }
 
 TEST_F(SaveCardBubbleControllerImplTest, Metrics_Local_Reshows_CancelButton) {
   ShowLocalBubble();
   CloseAndReshowBubble();
 
   base::HistogramTester histogram_tester;
   controller()->OnCancelButton();
   controller()->OnBubbleClosed();
 
   histogram_tester.ExpectUniqueSample(
-      "Autofill.SaveCreditCardPrompt.Local.Reshows",
+      "Autofill.SaveCreditCardPrompt.Local.Reshows.PreviouslyAccepted",
       AutofillMetrics::SAVE_CARD_PROMPT_END_DENIED, 1);
 }
 
 TEST_F(SaveCardBubbleControllerImplTest,
+       Metrics_Local_FirstShow_CancelButton_FirstShow) {
+  base::HistogramTester histogram_tester;
+  ShowLocalBubble();
+  controller()->OnCancelButton();
+  controller()->OnBubbleClosed();
+
+  ShowLocalBubble();
+  controller()->OnCancelButton();
+  controller()->OnBubbleClosed();
+
+  EXPECT_THAT(
+      histogram_tester.GetAllSamples(
+          "Autofill.SaveCreditCardPrompt.Local.FirstShow.PreviouslyAccepted"),
+      ElementsAre(Bucket(AutofillMetrics::SAVE_CARD_PROMPT_SHOW_REQUESTED, 1),
+                  Bucket(AutofillMetrics::SAVE_CARD_PROMPT_SHOWN, 1),
+                  Bucket(AutofillMetrics::SAVE_CARD_PROMPT_END_DENIED, 1)));
+  EXPECT_THAT(
+      histogram_tester.GetAllSamples(
+          "Autofill.SaveCreditCardPrompt.Local.FirstShow.PreviouslyDenied"),
+      ElementsAre(Bucket(AutofillMetrics::SAVE_CARD_PROMPT_SHOW_REQUESTED, 1),
+                  Bucket(AutofillMetrics::SAVE_CARD_PROMPT_SHOWN, 1),
+                  Bucket(AutofillMetrics::SAVE_CARD_PROMPT_END_DENIED, 1)));
+}
+
+TEST_F(SaveCardBubbleControllerImplTest,
+       Metrics_Local_FirstShow_CancelButton_FirstShow_SaveButton_FirstShow) {
+  base::HistogramTester histogram_tester;
+  ShowLocalBubble();
+  controller()->OnCancelButton();
+  controller()->OnBubbleClosed();
+
+  ShowLocalBubble();
+  controller()->OnSaveButton();
+  controller()->OnBubbleClosed();
+
+  ShowLocalBubble();
+
+  EXPECT_THAT(
+      histogram_tester.GetAllSamples(
+          "Autofill.SaveCreditCardPrompt.Local.FirstShow.PreviouslyAccepted"),
+      ElementsAre(Bucket(AutofillMetrics::SAVE_CARD_PROMPT_SHOW_REQUESTED, 2),
+                  Bucket(AutofillMetrics::SAVE_CARD_PROMPT_SHOWN, 2),
+                  Bucket(AutofillMetrics::SAVE_CARD_PROMPT_END_DENIED, 1)));
+  EXPECT_THAT(
+      histogram_tester.GetAllSamples(
+          "Autofill.SaveCreditCardPrompt.Local.FirstShow.PreviouslyDenied"),
+      ElementsAre(Bucket(AutofillMetrics::SAVE_CARD_PROMPT_SHOW_REQUESTED, 1),
+                  Bucket(AutofillMetrics::SAVE_CARD_PROMPT_SHOWN, 1),
+                  Bucket(AutofillMetrics::SAVE_CARD_PROMPT_END_ACCEPTED, 1)));
+}
+
+TEST_F(SaveCardBubbleControllerImplTest,
        Metrics_Local_FirstShow_NavigateWhileShowing) {
   ShowLocalBubble();
 
   base::HistogramTester histogram_tester;
   // Fake-navigate after bubble has been visible for a long time.
   controller()->set_elapsed(base::TimeDelta::FromMinutes(1));
 
   controller()->SimulateNavigation();
 
   histogram_tester.ExpectUniqueSample(
-      "Autofill.SaveCreditCardPrompt.Local.FirstShow",
+      "Autofill.SaveCreditCardPrompt.Local.FirstShow.PreviouslyAccepted",
       AutofillMetrics::SAVE_CARD_PROMPT_END_NAVIGATION_SHOWING, 1);
 }
 
 TEST_F(SaveCardBubbleControllerImplTest,
        Metrics_Local_Reshows_NavigateWhileShowing) {
   ShowLocalBubble();
   CloseAndReshowBubble();
 
   base::HistogramTester histogram_tester;
   // Fake-navigate after bubble has been visible for a long time.
   controller()->set_elapsed(base::TimeDelta::FromMinutes(1));
   controller()->SimulateNavigation();
 
   histogram_tester.ExpectUniqueSample(
-      "Autofill.SaveCreditCardPrompt.Local.Reshows",
+      "Autofill.SaveCreditCardPrompt.Local.Reshows.PreviouslyAccepted",
       AutofillMetrics::SAVE_CARD_PROMPT_END_NAVIGATION_SHOWING, 1);
 }
 
 TEST_F(SaveCardBubbleControllerImplTest,
        Metrics_Local_FirstShow_NavigateWhileHidden) {
   ShowLocalBubble();
 
   base::HistogramTester histogram_tester;
   controller()->OnBubbleClosed();
   // Fake-navigate after bubble has been visible for a long time.
   controller()->set_elapsed(base::TimeDelta::FromMinutes(1));
   controller()->SimulateNavigation();
 
   histogram_tester.ExpectUniqueSample(
-      "Autofill.SaveCreditCardPrompt.Local.FirstShow",
+      "Autofill.SaveCreditCardPrompt.Local.FirstShow.PreviouslyAccepted",
       AutofillMetrics::SAVE_CARD_PROMPT_END_NAVIGATION_HIDDEN, 1);
 }
 
 TEST_F(SaveCardBubbleControllerImplTest,
        Metrics_Local_Reshows_NavigateWhileHidden) {
   ShowLocalBubble();
   CloseAndReshowBubble();
 
   base::HistogramTester histogram_tester;
   controller()->OnBubbleClosed();
   // Fake-navigate after bubble has been visible for a long time.
   controller()->set_elapsed(base::TimeDelta::FromMinutes(1));
   controller()->SimulateNavigation();
 
   histogram_tester.ExpectUniqueSample(
-      "Autofill.SaveCreditCardPrompt.Local.Reshows",
+      "Autofill.SaveCreditCardPrompt.Local.Reshows.PreviouslyAccepted",
       AutofillMetrics::SAVE_CARD_PROMPT_END_NAVIGATION_HIDDEN, 1);
 }
 
 TEST_F(SaveCardBubbleControllerImplTest, Metrics_Upload_FirstShow_LearnMore) {
   ShowUploadBubble();
 
   base::HistogramTester histogram_tester;
   controller()->OnLearnMoreClicked();
 
   histogram_tester.ExpectUniqueSample(
-      "Autofill.SaveCreditCardPrompt.Upload.FirstShow",
+      "Autofill.SaveCreditCardPrompt.Upload.FirstShow.PreviouslyAccepted",
       AutofillMetrics::SAVE_CARD_PROMPT_DISMISS_CLICK_LEARN_MORE, 1);
 }
 
 TEST_F(SaveCardBubbleControllerImplTest, Metrics_Upload_Reshows_LearnMore) {
   ShowUploadBubble();
   CloseAndReshowBubble();
 
   base::HistogramTester histogram_tester;
   controller()->OnLearnMoreClicked();
 
   histogram_tester.ExpectUniqueSample(
-      "Autofill.SaveCreditCardPrompt.Upload.Reshows",
+      "Autofill.SaveCreditCardPrompt.Upload.Reshows.PreviouslyAccepted",
       AutofillMetrics::SAVE_CARD_PROMPT_DISMISS_CLICK_LEARN_MORE, 1);
 }
 
 TEST_F(SaveCardBubbleControllerImplTest,
        Metrics_Upload_FirstShow_LegalMessageLink) {
   ShowUploadBubble();
 
   base::HistogramTester histogram_tester;
   controller()->OnLegalMessageLinkClicked(GURL("http://www.example.com"));
 
   histogram_tester.ExpectUniqueSample(
-      "Autofill.SaveCreditCardPrompt.Upload.FirstShow",
+      "Autofill.SaveCreditCardPrompt.Upload.FirstShow.PreviouslyAccepted",
       AutofillMetrics::SAVE_CARD_PROMPT_DISMISS_CLICK_LEGAL_MESSAGE, 1);
 }
 
 TEST_F(SaveCardBubbleControllerImplTest,
        Metrics_Upload_Reshows_LegalMessageLink) {
   ShowUploadBubble();
   CloseAndReshowBubble();
 
   base::HistogramTester histogram_tester;
   controller()->OnLegalMessageLinkClicked(GURL("http://www.example.com"));
 
   histogram_tester.ExpectUniqueSample(
-      "Autofill.SaveCreditCardPrompt.Upload.Reshows",
+      "Autofill.SaveCreditCardPrompt.Upload.Reshows.PreviouslyAccepted",
       AutofillMetrics::SAVE_CARD_PROMPT_DISMISS_CLICK_LEGAL_MESSAGE, 1);
 }
 
 // SAVE_CARD_PROMPT_END_INVALID_LEGAL_MESSAGE is only possible for
 // Upload.FirstShow.
 TEST_F(SaveCardBubbleControllerImplTest,
        Metrics_Upload_FirstShow_InvalidLegalMessage) {
   base::HistogramTester histogram_tester;
 
   // Legal message is invalid because it's missing the url.
   SetLegalMessage(
       "{"
       "  \"line\" : [ {"
       "     \"template\": \"Panda {0}.\","
       "     \"template_parameter\": [ {"
       "        \"display_text\": \"bear\""
       "     } ]"
       "  } ]"
       "}");
 
   EXPECT_THAT(
       histogram_tester.GetAllSamples(
-          "Autofill.SaveCreditCardPrompt.Upload.FirstShow"),
+          "Autofill.SaveCreditCardPrompt.Upload.FirstShow.PreviouslyAccepted"),
       ElementsAre(
           Bucket(AutofillMetrics::SAVE_CARD_PROMPT_SHOW_REQUESTED, 1),
           Bucket(AutofillMetrics::SAVE_CARD_PROMPT_END_INVALID_LEGAL_MESSAGE,
                  1)));
 }
 
 }  // namespace autofill